65219 - Do something about nsStringRecycler and nsCStringRecycler

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We need to do something about nsStringRecycler -- right now there are a
handful of users recycling their strings into it, but nobody is using it
to create strings, so it's just becoming a sort of a leak, I think. In
other words, a few (very few) string users call nsString::Recycle and
nsCString::Recycle, and nobody calls nsString::CreateString or
nsCString::CreateString.   Note that this has nothing to do with the more
commonly used but deprecated |Recycle| function defined in nsStr.h.

It also uses static constructors that (now that I added nsDeque to the
leak stats) show up on the leak stats.

Unless somebody thinks this we should all start using the string recycler
(and hook it up as a memory pressure observer), I propose that we get rid
of it.  It seems that it may well become somewhat obsolete with scc's
forthcoming string changes, anyway.  Any thoughts?

See:
http://lxr.mozilla.org/seamonkey/search?string=nsString%3A%3ARecycle
http://lxr.mozilla.org/seamonkey/search?string=nsCString%3A%3ARecycle
http://lxr.mozilla.org/seamonkey/search?string=CreateString

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

While I'm here, what's the status of nsString2x.{h,cpp}?

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch to remove

Comment 3

[Peter "jag" Annema]

r=jag

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

->0.9, since I haven't heard from scc on this

Comment 5

[Scott Collins]

nsString[2]x.[h,cpp] were never part of the build and have been CVS removed.

What is the status of this patch?  Stale?  Still good?  I'll investigate, but
let me know, I'm ready to do this work immediately.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

The patch has been in my tree through all the migration of files taking place
underneath it.  I'll attach a version against the current tree.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch against current tree

Comment 8

[Scott Collins]

Looks good to me, sr=scc.  If we can get an r=, I can check this in immediately.
 Applying it in my tree now.

Comment 9

[Peter "jag" Annema]

r=jag

Comment 10

[Scott Collins]

patch committed, thanks for the help dbaron :-)

Comment 11

[Scott Collins]

*** Bug 57035 has been marked as a duplicate of this bug. ***