Status

()

Core
Layout
--
trivial
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ms2ger, Assigned: Ms2ger)

Tracking

Trunk
mozilla6
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Having non-automated tests that nobody runs only serve to confuse people, and they will be in the history if anybody ever wants to do something about it.
Flags: in-testsuite-
(Assignee)

Comment 1

6 years ago
Created attachment 527833 [details]
Diffstat

Patch is too big to attach, so I'll just ask for review on the diffstat
Attachment #527833 - Flags: review?(dbaron)
So we're giving up on HTML finally?  Woo!

On a serious note, why aren't we converting these to automated tests?
(Assignee)

Comment 3

6 years ago
It would certainly be nice if someone stepped up to do that, but I don't see it happening. In any case, if such a hero would appear, he can always find these tests in the history.
The reason I've been hesitant to delete them in the past is that I do want them to be converted to automated tests...
Comment on attachment 527833 [details]
Diffstat

I suppose there's not particularly more value in converting the things that happened to be checked in here than anything else in bugzilla, so r=dbaron.
Attachment #527833 - Flags: review?(dbaron) → review+
Give other people a few days to object, though.  (Maybe send email to dev-tech-layout too?)
Works for me.

Comment 8

6 years ago
I share Davids wish to convert them but the source can be easily retrieved otherwise. r+
(Assignee)

Comment 9

6 years ago
Didn't get any comments on the newsgroup, so I went ahead:

http://hg.mozilla.org/mozilla-central/rev/5991f0ec6b34
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.