652263 - [Firefox] Remove now useless WIN32_REDIST_DIR env var

Status: RESOLVED INVALID

(Release Engineering :: General, defect, P5)

Description

[Serge Gautherie (:sgautherie)]

Examples:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1303493909.1303502325.7070.gz&fulltext=1
WINNT 5.2 mozilla-central build on 2011/04/22 10:38:29
{
  WIN32_REDIST_DIR=d:/msvs8/VC/redist/x86/Microsoft.VC80.CRT
}
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1303493910.1303500915.774.gz&fulltext=1
WINNT 5.2 mozilla-central leak test build on 2011/04/22 10:38:30
{
  WIN32_REDIST_DIR=d:/msvs8/VC/redist/x86/Microsoft.VC80.CRT
}

Bug 565774 comment 7:
{
Serge Gautherie (:sgautherie)      2011-02-16 05:42:38 PST

Ben, could you tell us where the Firefox WIN32_REDIST_DIR setting comes from?
(Afaics, not from build nor mozilla-central repositories...)
}

On debug builds, this has never been useful (and has been misused until bug 650699).

On optimized builds, this is useless on all builds with jemalloc enabled,
which is the case since mozilla-1.9.1 (Firefox 3.5),
except for valgrind builds [I don't know much about these...].
http://mxr.mozilla.org/build/search?string=able-jemalloc&case=1

Comment 1

[Serge Gautherie (:sgautherie)]

Fwiw, 'mozilla2/mobile' has
http://mxr.mozilla.org/build/search?string=WIN32_REDIST_DIR&case=1&find=%2Fbuildbot-configs%2Fmozilla2%2Fmobile%2Fwin32-i686%2F
"Found 8 matching lines in 8 files"

Comment 2

[Serge Gautherie (:sgautherie)]

Bug 678161 (& Co) made WIN32_REDIST_DIR useful again.