65228 - Tons and tons of errors in navigator.js

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[HJ]

After installing build 2001011104 I see tons of errors in the JavaScript console.
All errors are the same: focusedWindow is not defined (line 81)
I know that navigator.js is changed lately. But I just can't count the number of
errors, there are to many. So there must be something wrong in navigator.js.
Not sure where to put this, XP???

Comment 1

[Fabian Guisset]

It's still the same error caused by bug 56063 bud. It seems someone changed
navigator.js to use that code more often though. not a biggie.

Comment 2

[HJ]

Still the same, and still no solution. But getting worse!

Comment 3

[John Morrison]

Actually, this is different (although the error message is similar).
I think the other bug has gone away. This bug is just due to a bit
of over-eager spring cleaning -- the temp var was needed after all.

-> blake, r=jrgm :-]


Index: navigator.js
===================================================================
RCS file: /cvsroot/mozilla/xpfe/browser/resources/content/navigator.js,v
retrieving revision 1.279
diff -u -r1.279 navigator.js
--- navigator.js        2001/01/09 04:22:09     1.279
+++ navigator.js        2001/01/13 03:32:41
@@ -77,6 +77,7 @@
 // When a content area frame is focused, update the focused frame URL
 function contentAreaFrameFocus()
 {
+  var focusedWindow = document.commandDispatcher.focusedWindow;
   if (isDocumentFrame(document.commandDispatcher.focusedWindow)) {
     gFocusedURL = focusedWindow.location.href;
     var saveFrameItem = document.getElementById("savepage");

Comment 4

[John Morrison]

Duh!

Index: navigator.js
===================================================================
RCS file: /cvsroot/mozilla/xpfe/browser/resources/content/navigator.js,v
retrieving revision 1.279
diff -u -r1.279 navigator.js
--- navigator.js        2001/01/09 04:22:09     1.279
+++ navigator.js        2001/01/13 03:37:11
@@ -77,7 +77,8 @@
 // When a content area frame is focused, update the focused frame URL
 function contentAreaFrameFocus()
 {
-  if (isDocumentFrame(document.commandDispatcher.focusedWindow)) {
+  var focusedWindow = document.commandDispatcher.focusedWindow;
+  if (isDocumentFrame(focusedWindow)) {
     gFocusedURL = focusedWindow.location.href;
     var saveFrameItem = document.getElementById("savepage");
     saveFrameItem.removeAttribute("hidden");

Comment 5

[Peter "jag" Annema]

Heh, doh. r=jag

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

oops. a=[e-mail]

Comment 7

[Peter "jag" Annema]

Marking fixed. Nice catch, John

Comment 8

[John Morrison]

Thanks. (and fixed).

Comment 9

[John Morrison]

... and verified through rigorous testing of the daily build.

Comment 10

[HJ]

Hey dude, thank you very mutcho's!