652327 - Toolkit's Add-on Manager is now Add-ons Manager, update SeaMonkey's "Tools" menu label

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[rsx11m]

Toolkit has changed "Add-on Manager" to "Add-ons Manager" now, thus respective UI elements will need updating. I'll file a separate bug for updating the Help content as it may need further updates and wiring beyond that, also to distinguish between comm-central and comm-2.0 changes.

Comment 1

[rsx11m]

I expected to find more references of "Add-on Manager" that need to be updated, but apparently the only case other than Help (covered by bug 652328) is in the "Tools" menu of all windows. I'll post a patch tomorrow unless anybody is aware of any other label that needs to be changed.

Comment 2

[Jens Hatlak (:InvisibleSmiley)]

FTR: This seems to at least go back all the way to bug 554007 which landed 2010-04-29. Firefox's menu entry reads "Add-ons", though.

Comment 3

[rsx11m]

Yes, Firefox doesn't use the "Manager" in their menu. However, SeaMonkey has "Data Manager", "Password Manager", and "Download Manager" already, thus I'd keep it "Add-ons Manager" for consistency (and it's also the tab title).

Comment 4

[rsx11m]

Attachment: Patch for new label [Checkin: comment 7]

This patch contains just a single label change in tasksOverlay which applies to the Tools > Add-on(s) menu in all windows. I'm not changing any use of "addon" to "addons" in the code, that would be overdoing it given that the two terms are almost identical and no ambiguity occurs.

Following Edmund's tradition introduced in bug 606482 to use "addOnsManager", and given that entity names are case insensitive, I've changed those in this way so that localizers will pick it up (Jens, let me know if you think that this wouldn't suffice as entity change).

Comment 5

[[e-mail]]

Sigh. Our l10n story sucks that we can't just add an "s" without a rewrite...

Comment 6

[rsx11m]

Yeah, it sure would be nice if such content changes could be picked up by l10n without the need for inventing new entity names all the time.

Push for trunk please (this won't go into comm-2.0).

Comment 7

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 528006 [details] [diff] [review]
Patch for new label [Checkin: comment 7]

http://hg.mozilla.org/comm-central/rev/0c9c4a20b02a