Closed
Bug 652371
Opened 14 years ago
Closed 14 years ago
Make use of utilityOverlay's menu_View
Categories
(SeaMonkey :: UI Design, defect)
SeaMonkey
UI Design
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.2
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
Attachments
(1 file)
6.61 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
At the moment we make little use of utilityOverlay's view_Menu, this patch fixes that.
Attachment #527971 -
Flags: review?(neil)
Summary: Make use of utilityOverlay's view_Menu → Make use of utilityOverlay's menu_View
Attachment #527971 -
Attachment description: Make use of view_Menu patch v1.0 → Make use of menu_View patch v1.0
Comment 1•14 years ago
|
||
Comment on attachment 527971 [details] [diff] [review]
Make use of menu_View patch v1.0 [Checked in: Comment 2]
Review of attachment 527971 [details] [diff] [review]:
::: suite/locales/en-US/chrome/common/utilityOverlay.dtd
@@ +59,5 @@
<!ENTITY findTypeTextCmd.accesskey "x">
<!ENTITY findTypeLinksCmd.label "Find Links As You Type">
<!ENTITY findTypeLinksCmd.accesskey "k">
+<!ENTITY viewMenu.label "View">
Ah, those blasted tabs. I don't think it's worth changing them to spaces, as you run the risk of bikeshedding over how many. Would you mind just updating the access key to upper case and omitting the contentious changes?
Attachment #527971 -
Flags: review?(neil) → review+
Comment on attachment 527971 [details] [diff] [review]
Make use of menu_View patch v1.0 [Checked in: Comment 2]
Without utilityOverlay.dtd viewMenu.label entity change.
http://hg.mozilla.org/comm-central/rev/227ee418e968
Attachment #527971 -
Attachment description: Make use of menu_View patch v1.0 → Make use of menu_View patch v1.0 [Checked in: Comment 2]
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.2a1
You need to log in
before you can comment on or make changes to this bug.
Description
•