Closed Bug 652379 Opened 10 years ago Closed 10 years ago
place:folder=-1 returns a non-empty result
User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110423 Firefox/6.0a1 Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110423 Firefox/6.0a1 From the latest nightly build, "place:folder=-1" query returns non-empty result, is it intended? Reproducible: Always
what does it contain?
Component: Bookmarks & History → Places
Product: Firefox → Toolkit
QA Contact: bookmarks → places
I suppose a regression from bug 641074, we should return a valid result, but empty.
The result seems the History items. I'm not sure. You may create a bookmark for "place:folder=-1" to have a test.
Assignee: nobody → mak77
Status: NEW → ASSIGNED
Summary: Why "place:folder=-1" query returns non-empty result? → place:folder=-1 returns a non-empty result
Note that although "place:folder=-1" returns non-empty result, "place:folder=-2" works as expected. Strange!
I know, -1 is a special value we use for "not-bookmarked", and that's why it works differently. The above patch should fix that and also make it faster.
Comment on attachment 528773 [details] [diff] [review] patch v1.0 Patch looks fine. Is the warning really necessary?
Attachment #528773 - Flags: review?(dietrich) → review+
(In reply to comment #7) > Comment on attachment 528773 [details] [diff] [review] > patch v1.0 > > Patch looks fine. Is the warning really necessary? I want to be sure that we don't hit this path in tests (unless wanted), otherwise the written test would be garbage.
Whiteboard: [places-next-wanted] → [places-next-wanted][fixed-in-places]
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Verified with Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110430 Firefox/6.0a1. But what does "place:folder=FOOBAR" mean? It returns the same result as "place:folder=-1" did.
Status: RESOLVED → VERIFIED
(In reply to comment #11) > But what does "place:folder=FOOBAR" mean? In this case, the query doesn't parse because FOOBAR means nothing, so a generic history query is created, that's by design (even if surprising).
You need to log in before you can comment on or make changes to this bug.