Closed Bug 652399 Opened 10 years ago Closed 10 years ago

Using system libjpeg should disable building embedded libjpeg-turbo

Categories

(Firefox Build System :: General, defect)

All
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla7

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch Patch (obsolete) — Splinter Review
cf. summary
Attachment #527985 - Flags: review?(ted.mielczarek)
Assignee: nobody → mh+mozilla
Comment on attachment 527985 [details] [diff] [review]
Patch

Review of attachment 527985 [details] [diff] [review]:

r=me
Attachment #527985 - Flags: review?(ted.mielczarek) → review+
Attached patch Patch v2Splinter Review
I don't know how I thought the previous patch was okay, but it turns out MOZ_LIBJPEG_TURBO is set to 1 unconditionally after it was set to nothing by the patch, so it was pointless.
Attachment #527985 - Attachment is obsolete: true
Attachment #529453 - Flags: review?(ted.mielczarek)
Comment on attachment 529453 [details] [diff] [review]
Patch v2

Review of attachment 529453 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #529453 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/dc9cf2842794
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
Depends on: 675568
Target Milestone: mozilla6 → mozilla7
The push from comment 5 was to the relbranch, not the default branch. Properly backed out on beta: http://hg.mozilla.org/releases/mozilla-beta/rev/eeabcaa28b68
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.