652461 - Edit dialog: the Privacy menu item generates an error "event is undefined"

Status: RESOLVED FIXED

(Calendar :: Dialogs, defect)

Description

[Decathlon]

Steps to reproduce:
1. Create a new event or edit an existing one;
2. go to the menu Options -> Privacy and select one of the three sub-items;

-> the error "event is undefined" appears in the console and, neither the sub-menu item get selected, nor the relate icon appears in the status bar.

Comment 1

[Decathlon]

Attachment: [short]patch - v1

In the function "editPrivacy()", the parameter "event" is being passed only when using the popup-menu in the "Privacy" toolbar button, and not with the item in the main menu (the goal is to stop the event propagation in order to avoid the issue described in bug 362948 comment 14). Hence we can ignore the event when it is undefined.
It could be fixed in some other way, but I think this is the simplest.

Comment 2

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 528021 [details] [diff] [review]
[short]patch - v1

r=philipp

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/405dba20aa4f>
Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/1f55c7285535>

-> FIXED