Edit dialog: the Privacy menu item generates an error "event is undefined"

RESOLVED FIXED in 1.0b4

Status

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: bv1578, Assigned: bv1578)

Tracking

Trunk
1.0b4

Details

Attachments

(1 attachment)

Steps to reproduce:
1. Create a new event or edit an existing one;
2. go to the menu Options -> Privacy and select one of the three sub-items;

-> the error "event is undefined" appears in the console and, neither the sub-menu item get selected, nor the relate icon appears in the status bar.
In the function "editPrivacy()", the parameter "event" is being passed only when using the popup-menu in the "Privacy" toolbar button, and not with the item in the main menu (the goal is to stop the event propagation in order to avoid the issue described in bug 362948 comment 14). Hence we can ignore the event when it is undefined.
It could be fixed in some other way, but I think this is the simplest.
Attachment #528021 - Flags: review?(philipp)
Comment on attachment 528021 [details] [diff] [review]
[short]patch - v1

r=philipp
Attachment #528021 - Flags: review?(philipp) → review+
Keywords: checkin-needed
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/405dba20aa4f>
Backported to comm-miramar <http://hg.mozilla.org/releases/comm-miramar/rev/1f55c7285535>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.0b4
You need to log in before you can comment on or make changes to this bug.