Closed
Bug 652473
Opened 13 years ago
Closed 13 years ago
PlacesUIUtils deprecation messages need to lay off the whitespace
Categories
(Firefox :: Bookmarks & History, defect)
Firefox
Bookmarks & History
Tracking
()
VERIFIED
FIXED
Firefox 6
People
(Reporter: philor, Assigned: philor)
Details
(Whiteboard: [fixed-in-places])
Attachments
(1 file)
2.70 KB,
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
STR: 1. Load http://blog.mozilla.com/feed/ 2. Open the error console 3. Change back from whatever you actually use to "Subscribe to this feed using Live Bookmarks" 4. Click Subscribe Now and watch the error console Expected results: (Well, besides not getting deprecation messages about our own UI.) Messages with one space between words. Actual results: [[[ Error: showMinimalAddLivemarkURI is deprecated and will be removed in a future release. Use showBookmarkDialog instead ]]] [[[ Error: The api has changed. A window should be passed to PUIU_showBookmarkDialog. Not passing a window will throw in a future release. ]]] with 20 or so spaces between what look to someone who hasn't looked at the wrapping in the source like random words.
Attachment #528038 -
Flags: review?(mak77)
Comment 1•13 years ago
|
||
> (Well, besides not getting deprecation messages about our own UI.) Messages > with one space between words. this is bug 629371, it's an easy bug to fix. > with 20 or so spaces between what look to someone who hasn't looked at the > wrapping in the source like random words. Yes, I noticed this but never found the time to fix it, so thank you for the patch!
Comment 2•13 years ago
|
||
Comment on attachment 528038 [details] [diff] [review] fix Review of attachment 528038 [details] [diff] [review]: r=me
Attachment #528038 -
Flags: review?(mak77) → review+
Updated•13 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Comment 3•13 years ago
|
||
http://hg.mozilla.org/projects/places/rev/4c616579cdfa
Whiteboard: [fixed-in-places]
Comment 4•13 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/4c616579cdfa
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 6
Verified Fixed on Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110504 Firefox/6.0a1
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•