652473 - PlacesUIUtils deprecation messages need to lay off the whitespace

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: fix

STR:
1. Load http://blog.mozilla.com/feed/
2. Open the error console
3. Change back from whatever you actually use to "Subscribe to this feed using Live Bookmarks"
4. Click Subscribe Now and watch the error console

Expected results:
(Well, besides not getting deprecation messages about our own UI.) Messages with one space between words.

Actual results:

[[[
Error: showMinimalAddLivemarkURI is deprecated and will be removed in a                    future release.  Use showBookmarkDialog instead
]]]

[[[
Error: The api has changed. A window should be                                     passed to PUIU_showBookmarkDialog.  Not                                     passing a window will throw in a future                                     release.
]]]

with 20 or so spaces between what look to someone who hasn't looked at the wrapping in the source like random words.

Comment 1

[Marco Bonardo [:mak]]

> (Well, besides not getting deprecation messages about our own UI.) Messages
> with one space between words.

this is bug 629371, it's an easy bug to fix.

> with 20 or so spaces between what look to someone who hasn't looked at the
> wrapping in the source like random words.

Yes, I noticed this but never found the time to fix it, so thank you for the patch!

Comment 2

[Marco Bonardo [:mak]]

Comment on attachment 528038 [details] [diff] [review]
fix

Review of attachment 528038 [details] [diff] [review]:

r=me

Comment 3

[Marco Bonardo [:mak]]

http://hg.mozilla.org/projects/places/rev/4c616579cdfa

Comment 4

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/4c616579cdfa

Comment 5

[Vlad [QA]]

Verified Fixed on Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110504 Firefox/6.0a1