The default bug view has changed. See this FAQ.

[OS/2] make package fails to generate startupCache.zip

RESOLVED FIXED in mozilla8

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Walter Meinl, Assigned: Walter Meinl)

Tracking

unspecified
mozilla8
x86
OS/2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
User-Agent:       Mozilla/5.0 (OS/2; Warp 4.5; rv:6.0a1) Gecko/20110425 Firefox/6.0a1
Build Identifier: 

[E:\mozbuild7\dist\firefox]set BEGINLIBPATH=..\..\DIST\bin;E:\usr\local441\lib;E:\usr\lib;E:\GLIBIDL\gcc335\lib;E:\PERL\lib;E:\MOZTOOLS;E:\EMX\dll;E:\python26; 

[E:\mozbuild7\dist\firefox]set LIBPATHSTRICT=T 

[E:\mozbuild7\dist\firefox]E:\MOZBUILD7\BROWSER\INSTALLER\..\..\DIST\BIN\XPCSHELL.EXE -g "" -f E:/hg-src/hg/mozilla-aurora/browser/installer/precompile_cache.js -e "populate_startupcache("omni.jar", "startupCache.zip");" 
SetGREDir failed.
unzip:  cannot find either startupCache.zip or startupCache.zip.zip.
make.exe[2]: *** [make-package] Error 9

Note "$$PWD" gets resolved to an empty string

exchanging "$$PWD" to "$(CURDIR)" resolves it to "$objdir/browser/installer" but then it fails with
E:\MOZBUILD1\BROWSER\INSTALLER\..\..\DIST\BIN\XPCSHELL.EXE -g E:/mozbuild1/browser/installer -f E:/hg-src/hg/comm-central/mozilla/browser/installer/precompile_cache.js -e "populate_startupcache("omni.jar", "startupCache.zip");"
-e:1: ReferenceError: omni is not defined


Reproducible: Always
(Assignee)

Updated

6 years ago
Blocks: 633645

Comment 1

6 years ago
IIRC ash has a bug where $PWD is not set until a cd is issued, eg cd ./.
(pdk)sh.exe does not have this bug.
(Assignee)

Comment 2

6 years ago
(In reply to comment #1)
> IIRC ash has a bug where $PWD is not set until a cd is issued, eg cd ./.
> (pdk)sh.exe does not have this bug.

When I put PWD in brackets "$$(PWD)", the GreDir is setup properly. However still I see then 
-e:1: ReferenceError: omni is not defined (as if the "." in omni.jar is somehow taken as a delimiter)
(Assignee)

Comment 3

6 years ago
(In reply to comment #1)
> IIRC ash has a bug where $PWD is not set until a cd is issued, eg cd ./.
> (pdk)sh.exe does not have this bug.

(In reply to comment #2)
 
> When I put PWD in brackets "$$(PWD)", the GreDir is setup properly.
While this works with our ash.exe, it doesn't build on linux
You are right, the PWD problem is due to ash, with pdksh it gets resolved properly.
> However, still I see then 
> -e:1: ReferenceError: omni is not defined (as if the "." in omni.jar is somehow
> taken as a delimiter)
The second problem seems to be caused by quotation. It doesn't work with pdksh as well. But when I use single quotes for 'omni.jar', 'startupCache.zip' it works.
(Assignee)

Comment 4

6 years ago
Created attachment 530903 [details] [diff] [review]
patch working with (pdk)sh

as explained in comment#3
(Assignee)

Comment 5

6 years ago
Created attachment 551232 [details] [diff] [review]
change quotation marks

This works with ash (with a little workaround for the bug in ash) and ksh and sh
Assignee: nobody → wuno
Attachment #530903 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #551232 - Flags: review?(mh+mozilla)
Attachment #551232 - Flags: review?(mh+mozilla) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 6

6 years ago
Created attachment 551553 [details] [diff] [review]
updated for check-in

to apply cleanly after check-in 1762d5d119fb for bug674352
http://hg.mozilla.org/integration/mozilla-inbound/rev/682ad2a5f003
Keywords: checkin-needed
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/682ad2a5f003
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.