652542 - "Ignore warning" link on view source pages no longer works

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Bug 546857 changed the browser.js handler to click (since blockedSite.xhtml no longer uses a xul:button, so command events are no longer fired), but didn't update the similar code in viewSource.js.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

I figured there's no need to try be smart about when to attach the listener the way browser.js does, view-source is used less and it's OK to just always have a click listener on it, I think.

Comment 2

[[e-mail]]

Comment on attachment 528107 [details] [diff] [review]
patch

Review of attachment 528107 [details] [diff] [review]:

::: toolkit/components/viewsource/content/viewSource.js
@@ +276,5 @@
   }
 }
 
 /**
  * Handle command events bubbling up from error page content

Nit: comment needs changing

@@ -324,5 @@
       }
     } else if (target == errorDoc.getElementById('ignoreWarningButton')) {
-      // Allow users to override and continue through to the site,
-      // but add a notify bar as a reminder, so that they don't lose
-      // track after, e.g., tab switching.

I can't comment on this comment change, since I have no idea why you're changing it.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

The view source window doesn't add the notification bar. Compare it to the browser.js code from where that comment was copied.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(I updated the comment with s/command/click/ locally)

Comment 5

[[e-mail]]

Comment on attachment 528107 [details] [diff] [review]
patch

Ah, that makes sense then, thanks.

Comment 6

[Dão Gottwald [:dao]]

(In reply to comment #4)
> (I updated the comment with s/command/click/ locally)

This change still needs to be applied before pushing the patch.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/661247ec9748