65269 - MacOS Trunk builds do not have Talkback enabled.

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Jay Patel [:jay]]

Sometime between 12/08 and 12/09 Talkback stopped receiving blackboxes from 
MacOS users.  The datafiles we use to generate Trunk Topcrash and MTBF reports 
do not have any MacOS data.  We need to get Talkback activated in the Trunk 
builds ASAP.

Comment 1

[J.J. Enser]

I'm on it.
I detected the problem during the holidays and reported it on 12/28. 2 variables 
are used in the mac build scripts to handle fullcircle/talkback related issues. 
build{talkback} and MOZ_FULLCIRCLE.
By default the former is defined while the latter is not, but it IS defined in 
the local prefs on the release build mac. However, the build behaves as if 
MOZ_FULLCIRCLE was not defined.

I will debug further the build process to try and understand why this happens.

Ref: ns/build/mac/build_scripts/NetscapeBuildList.pm, lines 817-835

Comment 2

[J.J. Enser]

I have a fix. the problem was caused by the syntax "$dist_dir:TalkBack" in the 
build script, where $dist_dist value was already containing a trailing colon, so 
there was one too many colon in the path.

to avoid multiple calls to ($dist_dir . "TalkBack"), I added a variable.
see (and review) coming patch.

Comment 3

[J.J. Enser]

Attachment: patch to ns/build/mac/build_scripts/NetscapeBuildList.pm

Comment 4

[J.J. Enser]

Oops I marked this one fixed a little too early. Reopening, and will mark fixed 
again after the patch is reviewed and checked in.

Comment 5

[Simon Fraser [no longer active]]

Good catch. sr=sfraser

Comment 6

[J.J. Enser]

fix checked in.

Comment 7

[Jon Granrose]

verified.