Closed Bug 652692 Opened 8 years ago Closed 8 years ago

Remove extensionsManagerOverlay.xul

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: mossop, Assigned: mossop)

Details

Attachments

(1 file, 1 obsolete file)

This was here to add the browser menu to the extensions manager window back when it was a separate window. Now it is just useless.
Attached patch patch rev 1 (obsolete) — Splinter Review
Attachment #528223 - Flags: review?(gavin.sharp)
Whiteboard: [has patch][needs review gavin]
Isn't it still possible for the dialog to be opened as a separate window? nsBrowserGlue.js seems to do that:

http://hg.mozilla.org/mozilla-central/annotate/3007eb62abc4/browser/components/nsBrowserGlue.js#l400

I guess changes to the structure of extensions.xul broke the overlay anyways (no longer a <window> with ID "extensionsManager"), but perhaps we should fix it instead of getting rid of it?
Huh, I don;t think that code can be used anymore and I thought we had removed it already. I'll be replaced by the third party work that is coming. I'll update this patch to remove it. We shouldn't be opening the add-ons manager in a window in Firefox anywhere now.
Attached patch patch rev 2Splinter Review
Attachment #528223 - Attachment is obsolete: true
Attachment #528223 - Flags: review?(gavin.sharp)
Attachment #528423 - Flags: review?(gavin.sharp)
Attachment #528423 - Flags: review?(gavin.sharp) → review+
Whiteboard: [has patch][needs review gavin] → [has patch]
Landed: http://hg.mozilla.org/mozilla-central/rev/f1c6fc8175d2
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch]
You need to log in before you can comment on or make changes to this bug.