Remove extensionsManagerOverlay.xul

RESOLVED FIXED

Status

()

Firefox
General
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Trunk
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
This was here to add the browser menu to the extensions manager window back when it was a separate window. Now it is just useless.
(Assignee)

Comment 1

6 years ago
Created attachment 528223 [details] [diff] [review]
patch rev 1
Attachment #528223 - Flags: review?(gavin.sharp)
(Assignee)

Updated

6 years ago
Whiteboard: [has patch][needs review gavin]
Isn't it still possible for the dialog to be opened as a separate window? nsBrowserGlue.js seems to do that:

http://hg.mozilla.org/mozilla-central/annotate/3007eb62abc4/browser/components/nsBrowserGlue.js#l400

I guess changes to the structure of extensions.xul broke the overlay anyways (no longer a <window> with ID "extensionsManager"), but perhaps we should fix it instead of getting rid of it?
(Assignee)

Comment 3

6 years ago
Huh, I don;t think that code can be used anymore and I thought we had removed it already. I'll be replaced by the third party work that is coming. I'll update this patch to remove it. We shouldn't be opening the add-ons manager in a window in Firefox anywhere now.
(Assignee)

Comment 4

6 years ago
Created attachment 528423 [details] [diff] [review]
patch rev 2
Attachment #528223 - Attachment is obsolete: true
Attachment #528223 - Flags: review?(gavin.sharp)
Attachment #528423 - Flags: review?(gavin.sharp)
Attachment #528423 - Flags: review?(gavin.sharp) → review+
Whiteboard: [has patch][needs review gavin] → [has patch]
(Assignee)

Comment 5

6 years ago
Landed: http://hg.mozilla.org/mozilla-central/rev/f1c6fc8175d2
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Flags: in-litmus-
Resolution: --- → FIXED
Whiteboard: [has patch]
You need to log in before you can comment on or make changes to this bug.