Last Comment Bug 652692 - Remove extensionsManagerOverlay.xul
: Remove extensionsManagerOverlay.xul
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Dave Townsend [:mossop]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-25 16:00 PDT by Dave Townsend [:mossop]
Modified: 2011-04-28 14:27 PDT (History)
2 users (show)
dtownsend: in‑testsuite-
dtownsend: in‑litmus-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch rev 1 (4.28 KB, patch)
2011-04-25 16:53 PDT, Dave Townsend [:mossop]
no flags Details | Diff | Review
patch rev 2 (6.74 KB, patch)
2011-04-26 13:37 PDT, Dave Townsend [:mossop]
gavin.sharp: review+
Details | Diff | Review

Description Dave Townsend [:mossop] 2011-04-25 16:00:57 PDT
This was here to add the browser menu to the extensions manager window back when it was a separate window. Now it is just useless.
Comment 1 Dave Townsend [:mossop] 2011-04-25 16:53:39 PDT
Created attachment 528223 [details] [diff] [review]
patch rev 1
Comment 2 :Gavin Sharp [email: gavin@gavinsharp.com] 2011-04-26 12:52:52 PDT
Isn't it still possible for the dialog to be opened as a separate window? nsBrowserGlue.js seems to do that:

http://hg.mozilla.org/mozilla-central/annotate/3007eb62abc4/browser/components/nsBrowserGlue.js#l400

I guess changes to the structure of extensions.xul broke the overlay anyways (no longer a <window> with ID "extensionsManager"), but perhaps we should fix it instead of getting rid of it?
Comment 3 Dave Townsend [:mossop] 2011-04-26 13:10:23 PDT
Huh, I don;t think that code can be used anymore and I thought we had removed it already. I'll be replaced by the third party work that is coming. I'll update this patch to remove it. We shouldn't be opening the add-ons manager in a window in Firefox anywhere now.
Comment 4 Dave Townsend [:mossop] 2011-04-26 13:37:02 PDT
Created attachment 528423 [details] [diff] [review]
patch rev 2
Comment 5 Dave Townsend [:mossop] 2011-04-28 14:27:07 PDT
Landed: http://hg.mozilla.org/mozilla-central/rev/f1c6fc8175d2

Note You need to log in before you can comment on or make changes to this bug.