Open
Bug 65273
Opened 24 years ago
Updated 2 years ago
Necko needs to have a shutdown for protocol handlers
Categories
(Core :: Networking, defect, P5)
Core
Networking
Tracking
()
NEW
Future
People
(Reporter: dougt, Unassigned)
References
Details
(Whiteboard: [necko-would-take])
Necko needs to better manage the protocol handlers. It should allow protocol handlers to register with the IOService. Upon shutdown, the IOService should warn the protocol handlers that they should clean up (eg. cancel any outstanding connections). Necko's IOService should also hold on to the eventQueue service so that the handlers can post messages while they shutdown. Currently the IOService hold WeakReferences to all the handlers. Because of this lack of shutdown functionality, the nsFTPProtocolHandler needs to hold an unused reference to the IOService so that it can ensure its exists when shutdown occurs.
Comment 1•24 years ago
|
||
I agree.. this really needs to be cleaned up.
Comment 3•23 years ago
|
||
This bug is causing a crash on shutdown on Mac, after visiting an FTP site, because FTP attempts to disconnect the control connection after the nsSocketTransportService has been shut down. This causes the STS to attempt to set a pollable event for the socket transport thread after it has been joined. We had to add a hacky workaround in Mac's NSPR code for now.
OS: Windows 2000 → All
Hardware: PC → All
Target Milestone: Future → mozilla0.9.2
Reporter | ||
Comment 4•23 years ago
|
||
no way this is going to happen in the 0.9.3 milestone.
Target Milestone: mozilla0.9.3 → mozilla1.0
Comment 6•23 years ago
|
||
The Mac NSPR workaround for this bug is in attachment 36178 [details] [diff] [review], on bug 69285. These lines: + if (pollDesc->pollingThread->state == _PR_DEAD_STATE) + return PR_FAILURE; should be unnecessary.
Thanks! That was the bug I was concerned was dependent on this problem...
Comment 8•23 years ago
|
||
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 (you can query for this string to delete spam or retrieve the list of bugs I've moved)
Target Milestone: mozilla1.0 → mozilla1.0.1
Reporter | ||
Comment 9•22 years ago
|
||
moving neeti's futured bugs for triaging.
Assignee: neeti → new-network-bugs
Updated•8 years ago
|
Whiteboard: [necko-would-take]
Comment 10•7 years ago
|
||
Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258
Priority: P3 → P5
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•