Closed Bug 652753 Opened 9 years ago Closed 9 years ago

Remove listener and observer in head.js even if test is timed out

Categories

(Firefox :: Session Restore, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 6

People

(Reporter: hiro, Assigned: hiro)

Details

Attachments

(1 file)

Attached patch Proposed patchSplinter Review
waitForBrowserState and waitForSaveState use listener and observer but those are removed in its function. We should also use registerCleanupFunction in case of timeout.
Attachment #528271 - Flags: review?(paul)
Comment on attachment 528271 [details] [diff] [review]
Proposed patch

Patch looks good. Do you have any idea if there are cases where we're actually hitting this?
Attachment #528271 - Flags: review?(paul) → review+
It happened once on my local Windows XP VM, but at that time the VM was getting slow down due to unknown reason, and I do not remember which test case causes this, but anyway it happens if user runs tests which use waitForBrowserState or waitForSaveSatate on a slow machine. ;-)
Assignee: nobody → hiikezoe
Keywords: checkin-needed
Status: NEW → ASSIGNED
Keywords: checkin-needed
Whiteboard: [fixed in cedar]
Version: unspecified → Trunk
Pushed:
http://hg.mozilla.org/mozilla-central/rev/547d189ddfd9
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → Firefox 6
You need to log in before you can comment on or make changes to this bug.