Closed Bug 652761 Opened 9 years ago Closed 9 years ago

ABORT: half open complete but no item: 'index != -1' with embedded src port 80000

Categories

(Core :: Networking: HTTP, defect)

x86
All
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Tracking Status
firefox5 - fixed

People

(Reporter: bc, Assigned: mcmanus)

References

()

Details

(Keywords: assertion, testcase)

Attachments

(2 files, 1 obsolete file)

Attached file testcase
1. http://www.radiofunn.ro/
2. nsHttpConnectionMgr::nsHalfOpenSocket::~nsHalfOpenSocket() [nsHttpConnectionMgr.cpp : 1225 + 0x20]

<Embed type="application/x-mplayer2" src="http://www.example.com:80000">

mac,linux,winxp mozilla-central
bork! bork!
Summary: ABORT: ABORT: half open complete but no item: 'index != -1' with embedded src port 80000 → ABORT: half open complete but no item: 'index != -1' with embedded src port 80000
I'll investigate this first thing.
Assignee: nobody → mcmanus
Status: NEW → ASSIGNED
Attached patch fix out of range port v1 (obsolete) — Splinter Review
The problem, as you may have surmised, is due to the port 80,000 in the example and an early failure to create the transport object.

fix attached, complete with test case.

this bug is on aurora too, I'll need to go read some archived mail/posts to figure out what to do about that.
Attachment #528310 - Flags: review?(honzab.moz)
This is a trivial fix to an error path potential crash in the syn-retry FF5 feature - setting tracking flags to what I hope are appropriate values :)
Let us know when we have a patch ready for approval. We're likely to approve a reviewed patch here, but we won't be tracking this.
Comment on attachment 528310 [details] [diff] [review]
fix out of range port v1

I'd rather use RemoveElement and ignore its result here then.  It does the same but in more encapsulated way.  Also the code will be cleaner.

r=honzab with that.

Good catch.
Attachment #528310 - Flags: review?(honzab.moz) → review+
update from review comment 6 - carry forward r=honzab
Attachment #528310 - Attachment is obsolete: true
Attachment #528930 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/3723e9c3557e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Attachment #528930 - Flags: approval-mozilla-aurora?
Attachment #528930 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.