Created attachment 528284 [details] testcase 1. http://www.radiofunn.ro/ 2. nsHttpConnectionMgr::nsHalfOpenSocket::~nsHalfOpenSocket() [nsHttpConnectionMgr.cpp : 1225 + 0x20] <Embed type="application/x-mplayer2" src="http://www.example.com:80000"> mac,linux,winxp mozilla-central
I'll investigate this first thing.
Created attachment 528310 [details] [diff] [review] fix out of range port v1 The problem, as you may have surmised, is due to the port 80,000 in the example and an early failure to create the transport object. fix attached, complete with test case. this bug is on aurora too, I'll need to go read some archived mail/posts to figure out what to do about that.
This is a trivial fix to an error path potential crash in the syn-retry FF5 feature - setting tracking flags to what I hope are appropriate values :)
Let us know when we have a patch ready for approval. We're likely to approve a reviewed patch here, but we won't be tracking this.
Comment on attachment 528310 [details] [diff] [review] fix out of range port v1 I'd rather use RemoveElement and ignore its result here then. It does the same but in more encapsulated way. Also the code will be cleaner. r=honzab with that. Good catch.
Created attachment 528930 [details] [diff] [review] fix out of range port v2 update from review comment 6 - carry forward r=honzab