ABORT: half open complete but no item: 'index != -1' with embedded src port 80000

RESOLVED FIXED

Status

()

Core
Networking: HTTP
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bc, Assigned: mcmanus)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
x86
All
assertion, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox5- fixed)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Created attachment 528284 [details]
testcase

1. http://www.radiofunn.ro/
2. nsHttpConnectionMgr::nsHalfOpenSocket::~nsHalfOpenSocket() [nsHttpConnectionMgr.cpp : 1225 + 0x20]

<Embed type="application/x-mplayer2" src="http://www.example.com:80000">

mac,linux,winxp mozilla-central
(Reporter)

Comment 1

6 years ago
bork! bork!
Summary: ABORT: ABORT: half open complete but no item: 'index != -1' with embedded src port 80000 → ABORT: half open complete but no item: 'index != -1' with embedded src port 80000
(Assignee)

Comment 2

6 years ago
I'll investigate this first thing.
Assignee: nobody → mcmanus
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

6 years ago
Created attachment 528310 [details] [diff] [review]
fix out of range port v1

The problem, as you may have surmised, is due to the port 80,000 in the example and an early failure to create the transport object.

fix attached, complete with test case.

this bug is on aurora too, I'll need to go read some archived mail/posts to figure out what to do about that.
Attachment #528310 - Flags: review?(honzab.moz)
(Assignee)

Comment 4

6 years ago
This is a trivial fix to an error path potential crash in the syn-retry FF5 feature - setting tracking flags to what I hope are appropriate values :)
status-firefox5: --- → affected
tracking-firefox5: --- → ?
Blocks: 651635
Let us know when we have a patch ready for approval. We're likely to approve a reviewed patch here, but we won't be tracking this.
tracking-firefox5: ? → -
Comment on attachment 528310 [details] [diff] [review]
fix out of range port v1

I'd rather use RemoveElement and ignore its result here then.  It does the same but in more encapsulated way.  Also the code will be cleaner.

r=honzab with that.

Good catch.
Attachment #528310 - Flags: review?(honzab.moz) → review+
(Assignee)

Comment 7

6 years ago
Created attachment 528930 [details] [diff] [review]
fix out of range port v2

update from review comment 6 - carry forward r=honzab
Attachment #528310 - Attachment is obsolete: true
Attachment #528930 - Flags: review+
(Assignee)

Comment 8

6 years ago
http://hg.mozilla.org/mozilla-central/rev/3723e9c3557e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Attachment #528930 - Flags: approval-mozilla-aurora?

Updated

6 years ago
Attachment #528930 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 9

6 years ago
http://hg.mozilla.org/mozilla-aurora/rev/c90cd210cad3
status-firefox5: affected → fixed
You need to log in before you can comment on or make changes to this bug.