Open
Bug 652822
Opened 14 years ago
Updated 14 years ago
[TabMail] Mousewheel scroll on tab bar should change tab.
Categories
(SeaMonkey :: Tabbed Browser, defect)
SeaMonkey
Tabbed Browser
Tracking
(Not tracked)
ASSIGNED
People
(Reporter: philip.chee, Assigned: philip.chee)
References
Details
Attachments
(1 file)
|
1.87 KB,
patch
|
mnyromyr
:
review-
|
Details | Diff | Splinter Review |
In Bug 643294 I fixed the tabbrowser. Someone on Mozillazine mentioned that tab scrolling via the mouse wheel wasn't working in TabMail.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #528320 -
Flags: review?(mnyromyr)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 528320 [details] [diff] [review]
Patch v1.0 fixit.
It does work almost perfect, but doesn't suffice.
If you have more tabs open than fit into the line, the tab bar becomes scrollable horizontally. Your mouse scrolling then does not care if the selected tab is outside the visible area of the tabbar…
(For comparison: the browser will force the active tab to remain visible.)
Also, the destructor fixup seems to be unrelated (though correct).
Attachment #528320 -
Flags: review?(mnyromyr) → review-
|
|
Assignee | |
Comment 3•14 years ago
|
||
That's strange. This fix is exactly the same code that I used for the tabbrowser.xml case. What could be the difference?
You need to log in
before you can comment on or make changes to this bug.
Description
•