652976 - [css3-animations] warning "should already have refreshed style rule" with SVG animation and CSS animation

Status: RESOLVED WORKSFORME

(Core :: CSS Parsing and Computation, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox when loaded)

###!!! ABORT: should already have refreshed style rule: 'ea->mStyleRuleRefreshTime == mPresContext->RefreshDriver()->MostRecentRefresh()', file layout/style/nsAnimationManager.cpp, line 835

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm inclined to just merge GetAnimationRule and CheckAnimationRule (with the name GetAnimationRule, but the contents of CheckAnimationRule with GetAnimationRule merged in to it).  I think the assertion should probably just go.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: change NS_ABORT_IF_FALSE to NS_WARN_IF_FALSE

This assertion was just checking correctness, and in the cases we're seeing it I think there's not a correctness bug, just a performance problem in that we redo work (since we sometimes do style reresolution during a refresh driver notification prior to notifying the animation manager).

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 539362 [details] [diff] [review]
change NS_ABORT_IF_FALSE to NS_WARN_IF_FALSE

r=me

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/405374f8075e

(which does NOT make this bug fixed)

Comment 6

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/405374f8075e

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Testcase no longer warns on trunk.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a597e0067bee

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a597e0067bee

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/a597e0067bee

Comment 11

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion