653007 - Redirect clean up removes redirects to non-wiki-page URLs

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task)

Description

[[:Cww]]

If we get rid of htaccess controls, we should allow redirects to point to non KB articles (like the home page).

Comment 1

[James Socol [:jsocol, :james]]

As part of fixing this, please back out 7525e06 in a separate commit.

Comment 3

[Erik Rose [:erik][:erikrose]]

master: https://github.com/jsocol/kitsune/commit/00bbc858a1ba3d3ed612fe4a1a2e0980af13933f
next (2.8.1): http://github.com/jsocol/kitsune/commit/91fc84594741966d6d881f14d1850c356b7320b2

Comment 4

[Rebecca Billings [:rbillings]]

Is there a redirect I can test this on?

Comment 5

[Erik Rose [:erik][:erikrose]]

Probably. It's easy enough to make one: just put "REDIRECT [[http://www.example.com/]]" into a page, and see if it gets deleted when the KB rebuild runs. It shouldn't.

Comment 6

[James Socol [:jsocol, :james]]

(Shouldn't that be "REDIRECT [http://www.example.com]"?)

Comment 7

[Erik Rose [:erik][:erikrose]]

I can never keep them straight (says the guy making the MW parser).

Comment 8

[Rebecca Billings [:rbillings]]

So I added the redirect message above, waited, and after the kb rebuild [I'm assuming it happened as it'd been around an hour and the behavior changed], the page is now not found. 

ex: https://support-release.allizom.org/en-US/kb/abacus/edit

Comment 9

[Rebecca Billings [:rbillings]]

Was able to repro a second time [as there was a question of whether the first test was interfered with by a rabbit restart]:

https://support-release.allizom.org/en-US/kb/calligraphy/history

Comment 10

[Erik Rose [:erik][:erikrose]]

I shall have a look.

Comment 11

[Erik Rose [:erik][:erikrose]]

Hmm, I have been unable to reproduce that page deletion locally. I put "REDIRECT [http://www.example.com]" on a brand new wiki page, reviewed it, and approved it. Did you do anything materially different? I'm going to check out 2.8.1 proper (though it shouldn't make a difference) and have another try. I'm also going to try it on support-release myself.

Comment 12

[Rebecca Billings [:rbillings]]

I was able to repro this today on support-release using this article:
https://support-release.allizom.org/en-US/kb/changess/history

I picked an article, edited it, reviewed it and waited- the redirect worked for about 40 minutes until the kb rebuild- now it's page not found.

Comment 13

[Erik Rose [:erik][:erikrose]]

Checking out the next branch locally, I'm still unable to reproduce it. I suspect that celery didn't get restarted on support-release and so didn't pick up my change to the rebuild code. I've asked oremj to restart it, though he hasn't replied yet.

Since this isn't a regression as it stands now, we can still deploy this at 3pm. I wouldn't be surprised if it started working on production.

Comment 14

[Erik Rose [:erik][:erikrose]]

Started working after celery was restarted. It hadn't picked up the new task code.

Comment 15

[Rebecca Billings [:rbillings]]

Verified redirects are not deleted any longer.