Figure out why Visual Studio PGO miscompiles JSDOUBLE_IS_NAN

RESOLVED FIXED in mozilla9

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

Trunk
mozilla9
All
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
Created attachment 546008 [details] [diff] [review]
Use a bitwise version of JSDOUBLE_IS_NaN that Visual Studio PGO doesn't miscompile

I found in bug 653777 that this variant apparently doesn't trigger the MSVC miscompilation. However, the patch there was also moving the function, so I'll push to try to confirm this version is fine.
Attachment #546008 - Flags: review?(jimb)
Does MSVC2010 have the issue as well?
Created attachment 546102 [details] [diff] [review]
Use a bitwise version of JSDOUBLE_IS_NaN that Visual Studio PGO doesn't miscompile

JSDOUBLE_HI32_NAN needed to be moved, so I moved the whole block of defines
Attachment #546102 - Flags: review?(jimb)
Attachment #546008 - Attachment is obsolete: true
Attachment #546008 - Flags: review?(jimb)
Assignee: general → mh+mozilla

Comment 4

6 years ago
Comment on attachment 546102 [details] [diff] [review]
Use a bitwise version of JSDOUBLE_IS_NaN that Visual Studio PGO doesn't miscompile

Review of attachment 546102 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #546102 - Flags: review?(jimb) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/41e4d29fb76d
Whiteboard: [inbound]

Comment 6

6 years ago
https://hg.mozilla.org/mozilla-central/rev/41e4d29fb76d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla9
You need to log in before you can comment on or make changes to this bug.