Last Comment Bug 653056 - Figure out why Visual Studio PGO miscompiles JSDOUBLE_IS_NAN
: Figure out why Visual Studio PGO miscompiles JSDOUBLE_IS_NAN
Status: RESOLVED FIXED
[inbound]
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All Windows 7
: -- normal (vote)
: mozilla9
Assigned To: Mike Hommey [:glandium]
:
: Jason Orendorff [:jorendorff]
Mentors:
Depends on:
Blocks: 640494
  Show dependency treegraph
 
Reported: 2011-04-26 23:47 PDT by Mike Hommey [:glandium]
Modified: 2011-09-23 20:56 PDT (History)
6 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Use a bitwise version of JSDOUBLE_IS_NaN that Visual Studio PGO doesn't miscompile (1.33 KB, patch)
2011-07-14 14:57 PDT, Mike Hommey [:glandium]
no flags Details | Diff | Splinter Review
Use a bitwise version of JSDOUBLE_IS_NaN that Visual Studio PGO doesn't miscompile (2.16 KB, patch)
2011-07-14 23:44 PDT, Mike Hommey [:glandium]
jimb: review+
Details | Diff | Splinter Review

Description Mike Hommey [:glandium] 2011-04-26 23:47:25 PDT

    
Comment 1 Mike Hommey [:glandium] 2011-07-14 14:57:02 PDT
Created attachment 546008 [details] [diff] [review]
Use a bitwise version of JSDOUBLE_IS_NaN that Visual Studio PGO doesn't miscompile

I found in bug 653777 that this variant apparently doesn't trigger the MSVC miscompilation. However, the patch there was also moving the function, so I'll push to try to confirm this version is fine.
Comment 2 Ryan VanderMeulen [:RyanVM] 2011-07-14 15:25:03 PDT
Does MSVC2010 have the issue as well?
Comment 3 Mike Hommey [:glandium] 2011-07-14 23:44:21 PDT
Created attachment 546102 [details] [diff] [review]
Use a bitwise version of JSDOUBLE_IS_NaN that Visual Studio PGO doesn't miscompile

JSDOUBLE_HI32_NAN needed to be moved, so I moved the whole block of defines
Comment 4 Jim Blandy :jimb 2011-09-22 14:43:35 PDT
Comment on attachment 546102 [details] [diff] [review]
Use a bitwise version of JSDOUBLE_IS_NaN that Visual Studio PGO doesn't miscompile

Review of attachment 546102 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Comment 6 Ed Morley [:emorley] 2011-09-23 20:56:33 PDT
https://hg.mozilla.org/mozilla-central/rev/41e4d29fb76d

Note You need to log in before you can comment on or make changes to this bug.