653086 - clean up editor configuration lines in a11y files

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Trevor Saunders (:tbsaunde)]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:6.0a1) Gecko/20110425 Firefox/6.0a1
Build Identifier: 

before we tart reindenting atk/ to use 2 space t indents instead of 4 we should change the editor configuration lines to use 2 spaces instead of 4.  Also while doing this outside of atk/ there where a few files that had no such lines and many others that only  had emacs ones, make sure all these files have ones for both vim and emacs.

Reproducible: Always

Comment 1

[Trevor Saunders (:tbsaunde)]

Attachment: MAKE SURE EACH FILE IN ATK/ HAS BOTH VIM AND EMACS LINES SETUP FOR 2 SPACE INDENTS

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 528559 [details] [diff] [review]
MAKE SURE EACH FILE IN ATK/ HAS BOTH VIM AND EMACS LINES SETUP FOR 2 SPACE INDENTS

Review of attachment 528559 [details] [diff] [review]:

r=me

Comment 3

[alexander :surkov (:asurkov)]

landed - http://hg.mozilla.org/mozilla-central/rev/f9a978db8102

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Thanks!

Comment 5

[Ginn Chen]

It doesn't work for me.
I got
Error detected while processing modelines:
line    2:
E518: Unknown option: */

It works if I change
/* vim:expandtab:shiftwidth=2:tabstop=2: */
to
/* vim:expandtab:shiftwidth=2:tabstop=2:
 */

Comment 6

[alexander :surkov (:asurkov)]

Trevor, could you address comment #5 please?

Comment 7

[Trevor Saunders (:tbsaunde)]

(In reply to comment #6)
> Trevor, could you address comment #5 please?

Yeah, I notice the same issue too, I  took a quick look and we had this issue  in some files before, and I ended up just spreading it around all of atk/ :(    https://developer.mozilla.org/En/Mozilla_Coding_Style_Guide suggests /* vim: set ts=2 et sw=2 tw=80: * which works for me, does it work for Ginn?

Comment 8

[Trevor Saunders (:tbsaunde)]

Attachment: patch

I used the vim configuration suggested in 
https://developer.mozilla.org/En/Developer_Guide/Coding_Style
Ginn Fernando does this work for you? it seems to work for me.

Comment 9

[Trevor Saunders (:tbsaunde)]

landed http://hg.mozilla.org/mozilla-central/rev/78ad95eaf1f1