Closed
Bug 653120
Opened 15 years ago
Closed 15 years ago
Switch sBlockedScriptRunners to be an nsTArray
Categories
(Core :: DOM: Core & HTML, defect, P3)
Tracking
()
RESOLVED
FIXED
mozilla8
People
(Reporter: bzbarsky, Assigned: bzbarsky)
Details
Attachments
(1 file)
|
5.46 KB,
patch
|
sicking
:
review+
|
Details | Diff | Splinter Review |
Right now this is an nsCOMArray. Unfortunately, nsCOMArray::RemoveObjectsAt creates a temporary nsVoidArray and such. And we call sBlockedScriptRunners->RemoveObjectsAt unconditionally.
We should, imo, either switch to an nsTArray of nsCOMPtr or skip the remove call when we have nothing to remove. Or both.
Jonas, thoughts?
Sounds good to me.
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #550014 -
Flags: review?(jonas)
|
|
Assignee | |
Updated•15 years ago
|
Assignee: nobody → bzbarsky
Priority: -- → P3
Whiteboard: [need review]
Comment on attachment 550014 [details] [diff] [review]
Fix
Review of attachment 550014 [details] [diff] [review]:
-----------------------------------------------------------------
r=me
Attachment #550014 -
Flags: review?(jonas) → review+
|
|
Assignee | |
Updated•15 years ago
|
Whiteboard: [need review] → [need landing]
|
|
Assignee | |
Comment 4•15 years ago
|
||
Flags: in-testsuite-
Whiteboard: [need landing]
Target Milestone: --- → mozilla8
|
||
Comment 5•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•