Switch sBlockedScriptRunners to be an nsTArray

RESOLVED FIXED in mozilla8

Status

()

Core
DOM
P3
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bz, Assigned: bz)

Tracking

Trunk
mozilla8
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Right now this is an nsCOMArray.  Unfortunately, nsCOMArray::RemoveObjectsAt creates a temporary nsVoidArray and such.  And we call sBlockedScriptRunners->RemoveObjectsAt unconditionally.

We should, imo, either switch to an nsTArray of nsCOMPtr or skip the remove call when we have nothing to remove.  Or both.

Jonas, thoughts?
Sounds good to me.
Created attachment 550014 [details] [diff] [review]
Fix
Attachment #550014 - Flags: review?(jonas)
Assignee: nobody → bzbarsky
Priority: -- → P3
Whiteboard: [need review]
Comment on attachment 550014 [details] [diff] [review]
Fix

Review of attachment 550014 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #550014 - Flags: review?(jonas) → review+
Whiteboard: [need review] → [need landing]
http://hg.mozilla.org/integration/mozilla-inbound/rev/4dd0c8239b2b
Flags: in-testsuite-
Whiteboard: [need landing]
Target Milestone: --- → mozilla8
http://hg.mozilla.org/mozilla-central/rev/4dd0c8239b2b
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.