Closed Bug 653120 Opened 9 years ago Closed 8 years ago

Switch sBlockedScriptRunners to be an nsTArray

Categories

(Core :: DOM: Core & HTML, defect, P3)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla8

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Details

Attachments

(1 file)

Right now this is an nsCOMArray.  Unfortunately, nsCOMArray::RemoveObjectsAt creates a temporary nsVoidArray and such.  And we call sBlockedScriptRunners->RemoveObjectsAt unconditionally.

We should, imo, either switch to an nsTArray of nsCOMPtr or skip the remove call when we have nothing to remove.  Or both.

Jonas, thoughts?
Attached patch FixSplinter Review
Attachment #550014 - Flags: review?(jonas)
Assignee: nobody → bzbarsky
Priority: -- → P3
Whiteboard: [need review]
Comment on attachment 550014 [details] [diff] [review]
Fix

Review of attachment 550014 [details] [diff] [review]:
-----------------------------------------------------------------

r=me
Attachment #550014 - Flags: review?(jonas) → review+
Whiteboard: [need review] → [need landing]
http://hg.mozilla.org/integration/mozilla-inbound/rev/4dd0c8239b2b
Flags: in-testsuite-
Whiteboard: [need landing]
Target Milestone: --- → mozilla8
http://hg.mozilla.org/mozilla-central/rev/4dd0c8239b2b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.