Closed Bug 653129 Opened 9 years ago Closed 9 years ago

view creation code cleanup

Categories

(Core :: Web Painting, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: tnikkel, Assigned: tnikkel)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

No description provided.
Attached patch patchSplinter Review
We can remove a lot of useless create view calls.
Attachment #528600 - Flags: review?(roc)
Comment on attachment 528600 [details] [diff] [review]
patch

Review of attachment 528600 [details] [diff] [review]:

Lovely!

::: layout/base/nsCSSFrameConstructor.cpp
@@ +3202,5 @@
     }
   }
       
+  if (aBuildCombobox) {
+    nsContainerFrame::CreateViewForFrame(scrollFrame, aBuildCombobox);

s/aBuildCombobox/PR_TRUE/
Attachment #528600 - Flags: review?(roc) → review+
This was green on try.
Keywords: checkin-needed
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/fa8be020bfb4
Keywords: checkin-needed
Whiteboard: [needs landing]
Target Milestone: --- → mozilla6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Component: Layout: View Rendering → Layout: Web Painting
You need to log in before you can comment on or make changes to this bug.