Last Comment Bug 653129 - view creation code cleanup
: view creation code cleanup
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout: View Rendering (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla6
Assigned To: Timothy Nikkel (:tnikkel)
:
Mentors:
Depends on:
Blocks: 337801
  Show dependency treegraph
 
Reported: 2011-04-27 08:32 PDT by Timothy Nikkel (:tnikkel)
Modified: 2011-04-29 06:55 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (24.33 KB, patch)
2011-04-27 08:35 PDT, Timothy Nikkel (:tnikkel)
roc: review+
Details | Diff | Splinter Review
patch for checkin (24.33 KB, patch)
2011-04-27 17:54 PDT, Timothy Nikkel (:tnikkel)
no flags Details | Diff | Splinter Review

Description Timothy Nikkel (:tnikkel) 2011-04-27 08:32:31 PDT

    
Comment 1 Timothy Nikkel (:tnikkel) 2011-04-27 08:35:49 PDT
Created attachment 528600 [details] [diff] [review]
patch

We can remove a lot of useless create view calls.
Comment 2 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-04-27 17:44:56 PDT
Comment on attachment 528600 [details] [diff] [review]
patch

Review of attachment 528600 [details] [diff] [review]:

Lovely!

::: layout/base/nsCSSFrameConstructor.cpp
@@ +3202,5 @@
     }
   }
       
+  if (aBuildCombobox) {
+    nsContainerFrame::CreateViewForFrame(scrollFrame, aBuildCombobox);

s/aBuildCombobox/PR_TRUE/
Comment 3 Timothy Nikkel (:tnikkel) 2011-04-27 17:54:20 PDT
Created attachment 528764 [details] [diff] [review]
patch for checkin
Comment 4 Timothy Nikkel (:tnikkel) 2011-04-27 17:55:01 PDT
This was green on try.
Comment 5 Dão Gottwald [:dao] 2011-04-29 06:54:46 PDT
http://hg.mozilla.org/mozilla-central/rev/fa8be020bfb4

Note You need to log in before you can comment on or make changes to this bug.