The default bug view has changed. See this FAQ.

view creation code cleanup

RESOLVED FIXED in mozilla6

Status

()

Core
Layout: View Rendering
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: tnikkel, Assigned: tnikkel)

Tracking

(Blocks: 1 bug)

Trunk
mozilla6
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 528600 [details] [diff] [review]
patch

We can remove a lot of useless create view calls.
Attachment #528600 - Flags: review?(roc)
Comment on attachment 528600 [details] [diff] [review]
patch

Review of attachment 528600 [details] [diff] [review]:

Lovely!

::: layout/base/nsCSSFrameConstructor.cpp
@@ +3202,5 @@
     }
   }
       
+  if (aBuildCombobox) {
+    nsContainerFrame::CreateViewForFrame(scrollFrame, aBuildCombobox);

s/aBuildCombobox/PR_TRUE/
Attachment #528600 - Flags: review?(roc) → review+
(Assignee)

Comment 3

6 years ago
Created attachment 528764 [details] [diff] [review]
patch for checkin
(Assignee)

Comment 4

6 years ago
This was green on try.
Keywords: checkin-needed
Whiteboard: [needs landing]
http://hg.mozilla.org/mozilla-central/rev/fa8be020bfb4
Keywords: checkin-needed
Whiteboard: [needs landing]
Target Milestone: --- → mozilla6

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.