653129 - view creation code cleanup

Status: RESOLVED FIXED

(Core :: Web Painting, defect)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: patch

We can remove a lot of useless create view calls.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 528600 [details] [diff] [review]
patch

Review of attachment 528600 [details] [diff] [review]:

Lovely!

::: layout/base/nsCSSFrameConstructor.cpp
@@ +3202,5 @@
     }
   }
       
+  if (aBuildCombobox) {
+    nsContainerFrame::CreateViewForFrame(scrollFrame, aBuildCombobox);

s/aBuildCombobox/PR_TRUE/

Comment 3

[Timothy Nikkel (:tnikkel)]

Attachment: patch for checkin

Comment 4

[Timothy Nikkel (:tnikkel)]

This was green on try.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/fa8be020bfb4