The default bug view has changed. See this FAQ.

move layout/xul/base/test/* mochitests to mochitest-chrome to avoid enablePrivileges

RESOLVED FIXED

Status

()

Core
Layout
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [specialpowers])

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 528605 [details] [diff] [review]
move layout/xul/base/test/* from mochitest-plain -> chrome (1.0)

in the move to remove enablePrivilege with specialPowers, we have found that many tests don't make sense as mochitest plain.  

If any of these tests should be mochitest-plain, please speak up.
(Assignee)

Updated

6 years ago
Attachment #528605 - Flags: review?(ted.mielczarek)
(Assignee)

Updated

6 years ago
Whiteboard: [specialpowers]
It's not clear to me that this makes sense for test_bug511075.html.
Can you r? the original test author(s)? I don't have the domain knowledge to say whether moving them to chrome will break anything.
Assignee: nobody → jmaher

Updated

6 years ago
Blocks: 462483
Comment on attachment 528605 [details] [diff] [review]
move layout/xul/base/test/* from mochitest-plain -> chrome (1.0)

Review of attachment 528605 [details] [diff] [review]:
-----------------------------------------------------------------

The mechanical changes look fine. Please get review from a peer on these tests so we can ensure that you're not breaking anything the tests are intended to test.
Attachment #528605 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 4

6 years ago
Created attachment 534715 [details] [diff] [review]
move layout/xul/base/test/* from mochitest-plain -> chrome (2.0)

updated patch to remove test_resizer.xul (fails on osx and winxp) and test_splitter.xul (fails on winxp).  These are passing on try server.  I would like to get a review that these tests I am moving:
/layout/xul/base/test/test_bug381167.xhtml
/layout/xul/base/test/test_bug393970.xul
/layout/xul/base/test/test_bug477754.xul
/layout/xul/base/test/test_bug511075.html
/layout/xul/base/test/test_stack.xul

will still be testing the same functionality when run in the mochitest-chrome harness.
Attachment #528605 - Attachment is obsolete: true
Attachment #534715 - Flags: review?(bzbarsky)
Comment on attachment 534715 [details] [diff] [review]
move layout/xul/base/test/* from mochitest-plain -> chrome (2.0)

I honestly don't know.  Looks to me like it should be ok, but if you want to be sure check with the test authors?
Attachment #534715 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 6

6 years ago
ehsan, can to look at test_bug477754.xul and make sure that it would be ok as a mochitest-chrome test.

wladimir, cna you look at testUbug393970.xul and make sure that it would be ok as a mochitest-chrome test.

Neil, can you verify test_stack.xul is safe to move to mochitest-chrome.

Comment 7

6 years ago
Comment on attachment 534715 [details] [diff] [review]
move layout/xul/base/test/* from mochitest-plain -> chrome (2.0)

Changing test_bug393970.xul seems fine to me, this test was about chrome UI in the first place.
Attachment #534715 - Flags: review+
(Assignee)

Comment 8

6 years ago
http://hg.mozilla.org/mozilla-central/rev/85394deb049d
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(In reply to comment #6)
> ehsan, can to look at test_bug477754.xul and make sure that it would be ok as a
> mochitest-chrome test.

Sorry for the delay here.  FWIW, yes, this is fine.
You need to log in before you can comment on or make changes to this bug.