653220 - selftest #line directives must be stopped

Status: RESOLVED FIXED

(Tamarin Graveyard :: Tools, defect)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

The selftest infrastructure emits line directives embedded in the generated C++ code.

The emitted line directives are less useful than you might hope, because most tools aren't able to actually resolve them properly, since they are emitted as paths that are relative to the originating .st file (see Bug 477230), but this causes problems:

* The usual practice in the tools I have used (as far as I can tell) is to resolve relative paths with respect to the current working directory during the compilation process.

* Most debugging tools don't know what to do with .st files in the first place, so having the selftests point back to the .st file is of questionable utility

* As a special case of the first bullet above, our internal build infrastructure really should resolve relative paths in the same way that tools like gcc do.  The hack I put in for Bug 568237 did not do that (instead it resolved relative paths relative to the originating file), but this then conflicted with the relative paths generated by xplat in response to my fix for Bug 606989.  The bug caused by this conflict went hidden due to an artifact of the hack working when the build-products directory is kept in one particular place, but it was present and led to Bug 652544.

So, at this point it seems like the simplest thing to do would be to remove the #line directives entirely.  In personal communication some months ago, Lars mentioned that the #line emission within the selftests should go, so I suspect no one will object to my removing them.

Comment 1

[Lars T Hansen]

Consider this an R+ for whatever you come up with...

Comment 2

[Tamarin Bot]

changeset: 6238:6e55fc87c9a4
user:      Felix S Klock II <[e-mail]>
summary:   Bug 653220: remove selftest.as emission of #line directives (virtual r=lhansen).

http://hg.mozilla.org/tamarin-redux/rev/6e55fc87c9a4