Graphs no longer work on trunk

VERIFIED FIXED

Status

--
major
VERIFIED FIXED
8 years ago
2 years ago

People

(Reporter: bzbarsky, Assigned: rhelmer)

Tracking

Trunk
x86
Mac OS X
Dependency tree / graph

Details

Attachments

(1 attachment, 1 obsolete attachment)

Apparently they rely on the non-standard document.width/document.height and we removed those.  See bug 585877.
(Reporter)

Updated

8 years ago
Severity: normal → major
(Assignee)

Comment 1

8 years ago
(In reply to comment #0)
> Apparently they rely on the non-standard document.width/document.height and we
> removed those.  See bug 585877.

I see what you mean on graphs.mozilla.org

There is a new version (2.0) in the works on http://graphs.allizom.org (uses a nightly snapshot of production data), does everything look ok there? Does to me right now on latest Nightly.

I think it's worth fixing for 1.0 though.
Assignee: nobody → rhelmer
Status: NEW → ASSIGNED
(Reporter)

Comment 2

8 years ago
2.0 works, I'm told.
(Assignee)

Comment 3

8 years ago
Created attachment 528730 [details] [diff] [review]
use getComputedStyle instead of document.width

Replaced document.width with document.defaultView.getComputedStyle(document.body,null).getPropertyValue('width')
Attachment #528730 - Flags: review?(catlee)
Attachment #528730 - Flags: feedback?(bzbarsky)
(Reporter)

Comment 4

8 years ago
Comment on attachment 528730 [details] [diff] [review]
use getComputedStyle instead of document.width

This is fine, but you can just do |.width| instead of |.getPropertyValue("width")|.
Attachment #528730 - Flags: feedback?(bzbarsky) → feedback+
Also "getComputedStyle" instead of "document.defaultView.getComputedStyle"
(Assignee)

Comment 6

8 years ago
Created attachment 528802 [details] [diff] [review]
use getComputedStyle instead of document.width v2

More succinct version of attachment 528730 [details] [diff] [review]. Tested on both Firefox 4 and latest Nightly.

Thanks bz/sicking for additional review.

catlee, would you mind pushing this? I still don't seem to be able to push to hg.m.o/graphs, despite bug 635119.
Attachment #528730 - Attachment is obsolete: true
Attachment #528730 - Flags: review?(catlee)
Attachment #528802 - Flags: review?(catlee)
(Assignee)

Comment 7

8 years ago
Comment on attachment 528802 [details] [diff] [review]
use getComputedStyle instead of document.width v2

Problem with my hg account resolved, push changeset f7f5ddf4ee84
Attachment #528802 - Flags: review?(catlee)
(Assignee)

Comment 8

8 years ago
Stage updated:
http://graphs-stage.mozilla.org/graph.html

Filed serverops bug 653358 to push to prod.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Comment on attachment 528802 [details] [diff] [review]
use getComputedStyle instead of document.width v2

Looks like you pushed it already:

http://hg.mozilla.org/graphs/rev/f7f5ddf4ee84
Attachment #528802 - Flags: review+
(Assignee)

Updated

8 years ago
Depends on: 653358
(Assignee)

Comment 10

8 years ago
Pushed to prod, WFM - http://graphs.mozilla.org
Status: RESOLVED → VERIFIED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.