653233 - Graphs no longer work on trunk

Status: VERIFIED FIXED

(Webtools Graveyard :: Graph Server, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Apparently they rely on the non-standard document.width/document.height and we removed those.  See bug 585877.

Comment 1

[Robert Helmer [:rhelmer]]

(In reply to comment #0)
> Apparently they rely on the non-standard document.width/document.height and we
> removed those.  See bug 585877.

I see what you mean on graphs.mozilla.org

There is a new version (2.0) in the works on http://graphs.allizom.org (uses a nightly snapshot of production data), does everything look ok there? Does to me right now on latest Nightly.

I think it's worth fixing for 1.0 though.

Comment 2

[Boris Zbarsky [:bzbarsky]]

2.0 works, I'm told.

Comment 3

[Robert Helmer [:rhelmer]]

Attachment: use getComputedStyle instead of document.width

Replaced document.width with document.defaultView.getComputedStyle(document.body,null).getPropertyValue('width')

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 528730 [details] [diff] [review]
use getComputedStyle instead of document.width

This is fine, but you can just do |.width| instead of |.getPropertyValue("width")|.

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Also "getComputedStyle" instead of "document.defaultView.getComputedStyle"

Comment 6

[Robert Helmer [:rhelmer]]

Attachment: use getComputedStyle instead of document.width v2

More succinct version of attachment 528730 [details] [diff] [review]. Tested on both Firefox 4 and latest Nightly.

Thanks bz/sicking for additional review.

catlee, would you mind pushing this? I still don't seem to be able to push to hg.m.o/graphs, despite bug 635119.

Comment 7

[Robert Helmer [:rhelmer]]

Comment on attachment 528802 [details] [diff] [review]
use getComputedStyle instead of document.width v2

Problem with my hg account resolved, push changeset f7f5ddf4ee84

Comment 8

[Robert Helmer [:rhelmer]]

Stage updated:
http://graphs-stage.mozilla.org/graph.html

Filed serverops bug 653358 to push to prod.

Comment 9

[Chris AtLee [:catlee]]

Comment on attachment 528802 [details] [diff] [review]
use getComputedStyle instead of document.width v2

Looks like you pushed it already:

http://hg.mozilla.org/graphs/rev/f7f5ddf4ee84

Comment 10

[Robert Helmer [:rhelmer]]

Pushed to prod, WFM - http://graphs.mozilla.org