Closed Bug 653310 Opened 8 years ago Closed 8 years ago

ipc:content-shutdown notification maybe should always set a dumpID property

Categories

(Core :: IPC, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla6

People

(Reporter: heycam, Unassigned)

Details

Attachments

(1 file)

The test dom/ipc/tests/test_process_error.xul fails in my Ubuntu VM, due to breakpad not being able to attach to the crashing content process (which is apparently a known issue).  Since there's no minidump, the property bag that is sent as the subject of the ipc:content-shutdown notification does not have a "dumpID" property.  The test script throws when trying to get it, which causes the test timeout.

Plugin crashes OTOH always set a "pluginDumpID" property for plugin-crash notifications.  If there was no minidump available, it uses an empty string value.  modules/plugin/test/mochitest/test_crash_notify.xul (for example) will still fail, but it won't cause the test to timeout.

It seems like these two should be consistent.  Should we set dumpID = "" in this case?
Summary: ipc:content-shutdown notification maybe should always set a crashID property → ipc:content-shutdown notification maybe should always set a dumpID property
Sure.  And the test should still fail if dumpID == "", right?
Attachment #528790 - Flags: review?(jones.chris.g) → review+
(In reply to comment #2)
> Sure.  And the test should still fail if dumpID == "", right?

I was just going to echo this sentiment. It's fine to have the data be consistent, but if we're failing to write a dump we are still failing the test.
Landed: http://hg.mozilla.org/mozilla-central/rev/9f8e09d29a0d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.