Last Comment Bug 653310 - ipc:content-shutdown notification maybe should always set a dumpID property
: ipc:content-shutdown notification maybe should always set a dumpID property
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: IPC (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla6
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-04-27 17:38 PDT by Cameron McCormack (:heycam)
Modified: 2011-04-28 15:08 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Always put a dumpID property on ipc:content-shutdown notification property bags. (2.31 KB, patch)
2011-04-27 21:53 PDT, Cameron McCormack (:heycam)
cjones.bugs: review+
Details | Diff | Splinter Review

Description Cameron McCormack (:heycam) 2011-04-27 17:38:19 PDT
The test dom/ipc/tests/test_process_error.xul fails in my Ubuntu VM, due to breakpad not being able to attach to the crashing content process (which is apparently a known issue).  Since there's no minidump, the property bag that is sent as the subject of the ipc:content-shutdown notification does not have a "dumpID" property.  The test script throws when trying to get it, which causes the test timeout.

Plugin crashes OTOH always set a "pluginDumpID" property for plugin-crash notifications.  If there was no minidump available, it uses an empty string value.  modules/plugin/test/mochitest/test_crash_notify.xul (for example) will still fail, but it won't cause the test to timeout.

It seems like these two should be consistent.  Should we set dumpID = "" in this case?
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-04-27 21:17:29 PDT
Sounds good.  Should be a one-liner; want to write the patch? ;)  See http://mxr.mozilla.org/mozilla-central/source/dom/ipc/ContentParent.cpp#287 .
Comment 2 Cameron McCormack (:heycam) 2011-04-27 21:21:39 PDT
Sure.  And the test should still fail if dumpID == "", right?
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2011-04-27 21:24:08 PDT
Yep.
Comment 4 Cameron McCormack (:heycam) 2011-04-27 21:53:41 PDT
Created attachment 528790 [details] [diff] [review]
Always put a dumpID property on ipc:content-shutdown notification property bags.
Comment 5 Ted Mielczarek [:ted.mielczarek] 2011-04-28 05:14:26 PDT
(In reply to comment #2)
> Sure.  And the test should still fail if dumpID == "", right?

I was just going to echo this sentiment. It's fine to have the data be consistent, but if we're failing to write a dump we are still failing the test.
Comment 6 Cameron McCormack (:heycam) 2011-04-28 15:08:54 PDT
Landed: http://hg.mozilla.org/mozilla-central/rev/9f8e09d29a0d

Note You need to log in before you can comment on or make changes to this bug.