Closed Bug 653364 Opened 10 years ago Closed 10 years ago

isTrusted undefined on new hashchange event

Categories

(Core :: DOM: Navigation, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: john.p.baker, Assigned: justin.lebar+bug)

References

Details

(Keywords: regression)

Attachments

(1 file, 1 obsolete file)

My addon contains the following code

handleEvent : function bug420605_handleEvent(aEvent) {
    switch (aEvent.type) {

...

      case "hashchange":
        if (aEvent.isTrusted)
          this.onHashChange(aEvent);
        break;

...

aEvent.isTrusted is now undefined here.

bz in bug 628069 comment #19 replied:
> Hmm.  The classinfo for the new event doesn't include nsIDOMNSEvent.  That's
> true for popstate as well, looks like.

> John, can you please file a followup
> bug on that?
Attached patch Patch v1 (obsolete) — Splinter Review
I think popstate is fine, because it has DOM_CLASSINFO_EVENT_MAP_ENTRIES.  The
hashchange event had DOM_CLASSINFO_DOCUMENT_MAP_ENTRIES, which was problematic.

Anyway, I added tests for both popstate and hashchange.
Attachment #528898 - Flags: review?(bzbarsky)
Comment on attachment 528898 [details] [diff] [review]
Patch v1

Why the changes to dom/tests/mochitest/bugs/Makefile.in ?
Oops.  That was an errant hg revert --rev qparent.
Attached patch Patch v2Splinter Review
Un-removed tests, per comment 2
Attachment #528898 - Attachment is obsolete: true
Attachment #528898 - Flags: review?(bzbarsky)
Attachment #528941 - Flags: review?(bzbarsky)
Comment on attachment 528941 [details] [diff] [review]
Patch v2

r=me
Attachment #528941 - Flags: review?(bzbarsky) → review+
http://hg.mozilla.org/mozilla-central/rev/5efc266040c7
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee: nobody → justin.lebar+bug
You need to log in before you can comment on or make changes to this bug.