Closed
Bug 653364
Opened 12 years ago
Closed 12 years ago
isTrusted undefined on new hashchange event
Categories
(Core :: DOM: Navigation, defect)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
People
(Reporter: john.p.baker, Assigned: justin.lebar+bug)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
5.86 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
My addon contains the following code handleEvent : function bug420605_handleEvent(aEvent) { switch (aEvent.type) { ... case "hashchange": if (aEvent.isTrusted) this.onHashChange(aEvent); break; ... aEvent.isTrusted is now undefined here. bz in bug 628069 comment #19 replied: > Hmm. The classinfo for the new event doesn't include nsIDOMNSEvent. That's > true for popstate as well, looks like. > John, can you please file a followup > bug on that?
![]() |
||
Updated•12 years ago
|
tracking-firefox6:
--- → ?
Keywords: regression
Assignee | ||
Comment 1•12 years ago
|
||
I think popstate is fine, because it has DOM_CLASSINFO_EVENT_MAP_ENTRIES. The hashchange event had DOM_CLASSINFO_DOCUMENT_MAP_ENTRIES, which was problematic. Anyway, I added tests for both popstate and hashchange.
Attachment #528898 -
Flags: review?(bzbarsky)
![]() |
||
Comment 2•12 years ago
|
||
Comment on attachment 528898 [details] [diff] [review] Patch v1 Why the changes to dom/tests/mochitest/bugs/Makefile.in ?
Assignee | ||
Comment 3•12 years ago
|
||
Oops. That was an errant hg revert --rev qparent.
Assignee | ||
Updated•12 years ago
|
Attachment #528898 -
Attachment is obsolete: true
Attachment #528898 -
Flags: review?(bzbarsky)
Assignee | ||
Updated•12 years ago
|
Attachment #528941 -
Flags: review?(bzbarsky)
![]() |
||
Comment 5•12 years ago
|
||
Comment on attachment 528941 [details] [diff] [review] Patch v2 r=me
Attachment #528941 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 6•12 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/5efc266040c7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
tracking-firefox6:
? → ---
Updated•12 years ago
|
Assignee: nobody → justin.lebar+bug
You need to log in
before you can comment on or make changes to this bug.
Description
•