653364 - isTrusted undefined on new hashchange event

Status: RESOLVED FIXED

Description

[John P Baker]

My addon contains the following code

handleEvent : function bug420605_handleEvent(aEvent) {
    switch (aEvent.type) {

...

      case "hashchange":
        if (aEvent.isTrusted)
          this.onHashChange(aEvent);
        break;

...

aEvent.isTrusted is now undefined here.

bz in bug 628069 comment #19 replied:
> Hmm.  The classinfo for the new event doesn't include nsIDOMNSEvent.  That's
> true for popstate as well, looks like.

> John, can you please file a followup
> bug on that?

Comment 1

[Justin Lebar (not reading bugmail)]

Created attachment 528898 [details] [diff] [review]
Patch v1

I think popstate is fine, because it has DOM_CLASSINFO_EVENT_MAP_ENTRIES.  The
hashchange event had DOM_CLASSINFO_DOCUMENT_MAP_ENTRIES, which was problematic.

Anyway, I added tests for both popstate and hashchange.

Comment 2

[Boris Zbarsky [:bz]]

Comment on attachment 528898 [details] [diff] [review]
Patch v1

Why the changes to dom/tests/mochitest/bugs/Makefile.in ?

Comment 3

[Justin Lebar (not reading bugmail)]

Oops.  That was an errant hg revert --rev qparent.

Comment 4

[Justin Lebar (not reading bugmail)]

Created attachment 528941 [details] [diff] [review]
Patch v2

Un-removed tests, per comment 2

Comment 5

[Boris Zbarsky [:bz]]

Comment on attachment 528941 [details] [diff] [review]
Patch v2

r=me

Comment 6

[Justin Lebar (not reading bugmail)]

http://hg.mozilla.org/mozilla-central/rev/5efc266040c7