nsHTMLMediaElement should traverse/unlink mSourceLoadCandidate

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

8 years ago
mSourceLoadCandidate points to the child of the media element, and once
the mParent is made strong, there is a cycle which cycle collector doesn't know
about.
Assignee

Comment 1

8 years ago
Posted patch patchSplinter Review
The patch has the assumption that if mSourceLoadCandidate is set null
before NotifyLoadError or DecodeError, we have actually unlinked, and
should not call QueueLoadFromSourceTask, since that takes a strong
ref to the ownerDocument (which would cause leaks again).
Attachment #528840 - Flags: review?(chris)
Attachment #528840 - Flags: review?(chris) → review+
Assignee

Comment 2

8 years ago
http://hg.mozilla.org/mozilla-central/rev/5fe9c33c0c8f
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.