Closed Bug 653420 Opened 12 years ago Closed 12 years ago

nsHTMLMediaElement should traverse/unlink mSourceLoadCandidate

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Platform:
x86
All
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(1 file)

patch
3.08 KB, patch
cpearce
: review+
Details | Diff | Splinter Review 
mSourceLoadCandidate points to the child of the media element, and once
the mParent is made strong, there is a cycle which cycle collector doesn't know
about.
Attached patch patch — — Splinter Review 
The patch has the assumption that if mSourceLoadCandidate is set null
before NotifyLoadError or DecodeError, we have actually unlinked, and
should not call QueueLoadFromSourceTask, since that takes a strong
ref to the ownerDocument (which would cause leaks again).
Attachment #528840 - Flags: review?(chris)
Attachment #528840 - Flags: review?(chris) → review+
http://hg.mozilla.org/mozilla-central/rev/5fe9c33c0c8f
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.