Closed
Bug 653420
Opened 15 years ago
Closed 15 years ago
nsHTMLMediaElement should traverse/unlink mSourceLoadCandidate
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file)
|
3.08 KB,
patch
|
cpearce
:
review+
|
Details | Diff | Splinter Review |
mSourceLoadCandidate points to the child of the media element, and once
the mParent is made strong, there is a cycle which cycle collector doesn't know
about.
|
Assignee | |
Comment 1•15 years ago
|
||
The patch has the assumption that if mSourceLoadCandidate is set null
before NotifyLoadError or DecodeError, we have actually unlinked, and
should not call QueueLoadFromSourceTask, since that takes a strong
ref to the ownerDocument (which would cause leaks again).
Attachment #528840 -
Flags: review?(chris)
|
||
Updated•15 years ago
|
Attachment #528840 -
Flags: review?(chris) → review+
|
|
Assignee | |
Comment 2•15 years ago
|
||
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•