Undo option is grayed out although action is applicable in Scratchpad

VERIFIED FIXED in Firefox 7

Status

()

Firefox
Developer Tools
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: George Carstoiu, Unassigned)

Tracking

Trunk
Firefox 7
x86
All
Points:
---

Firefox Tracking Flags

(firefox7 fixed)

Details

(Whiteboard: [scratchpad][fixed-in-aurora])

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

6 years ago
Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110427 Firefox/6.0a1

Writing anything in the Workspaces window does not activate the Undo option from the Edit menu.

Reproducible: always

Steps to reproduce:
 1. Start Workspaces (F4)
 2. Write anything in the window
 3. Go to Edit->Undo

Actual results:
 - the Undo option is grayed out

Expected results:
 - after writing, the Undo button is active

Note:
 - although the button is not active, the shortcut can be used
(Reporter)

Updated

6 years ago
Whiteboard: [workspaces]

Comment 1

6 years ago
Created attachment 529471 [details] [diff] [review]
revealing the workspace menu item

Comment 2

6 years ago
(In reply to comment #1)
> Created attachment 529471 [details] [diff] [review] [review]
> revealing the workspace menu item

sorry this is meant for bug 654023 .. I'm not sure how to remove it..
you can probably mark it obsolete and maybe change the patch name to something indicating "not what you want, go elsewhere".

Comment 4

6 years ago
Created attachment 540297 [details] [diff] [review]
[in-fx-team] [in-aurora] Easy change to enable Undo menuitem.
Summary: Undo option is grayed out although action is applicable → Undo option is grayed out although action is applicable in Scratchpad
Whiteboard: [workspaces] → [scratchpad][has-patch]
Comment on attachment 540297 [details] [diff] [review]
[in-fx-team] [in-aurora] Easy change to enable Undo menuitem.

Nice!
Attachment #540297 - Flags: review+
Comment on attachment 540297 [details] [diff] [review]
[in-fx-team] [in-aurora] Easy change to enable Undo menuitem.

Would like to get this onto Aurora. It's a small polish fix.
Attachment #540297 - Flags: review?(gavin.sharp)
Attachment #540297 - Flags: approval-mozilla-aurora?
Comment on attachment 529471 [details] [diff] [review]
revealing the workspace menu item

patch doesn't apply to this bug. Marking obsolete to hide it from the list.
Attachment #529471 - Attachment is obsolete: true
Comment on attachment 540297 [details] [diff] [review]
[in-fx-team] [in-aurora] Easy change to enable Undo menuitem.

The ID change seems spurious, can you omit it?
Attachment #540297 - Flags: review?(gavin.sharp)
Attachment #540297 - Flags: review+
Attachment #540297 - Flags: approval-mozilla-aurora?
Attachment #540297 - Flags: approval-mozilla-aurora+
Just found this bug in my list. Needs a checkin.

(In reply to comment #8)
> Comment on attachment 540297 [details] [diff] [review] [review]
> Easy change to enable Undo menuitem.
> 
> The ID change seems spurious, can you omit it?

I think that change was so the id would be more consistent with the rest of the menu items. I think we should keep it.
Whiteboard: [scratchpad][has-patch] → [scratchpad][needs-checkin]
Whiteboard: [scratchpad][needs-checkin] → [scratchpad][fixed-in-fx-team]
Target Milestone: --- → Firefox 7
Whiteboard: [scratchpad][fixed-in-fx-team] → [scratchpad][fixed-in-fx-team][fixed-in-aurora]
Comment on attachment 540297 [details] [diff] [review]
[in-fx-team] [in-aurora] Easy change to enable Undo menuitem.

http://hg.mozilla.org/integration/fx-team/rev/11c3b74e18e7

http://hg.mozilla.org/releases/mozilla-aurora/rev/e259c21107fb
Attachment #540297 - Attachment description: Easy change to enable Undo menuitem. → [in-fx-team] [in-aurora] Easy change to enable Undo menuitem.
Attachment #540297 - Flags: approval-mozilla-beta?
can we land this on beta too?
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 12

6 years ago
Does this have loc impact? Can add-ons be relying on that id? (likely not, but checking).

It is way, way late in the game to get it on beta...
they can rely on it from beta onwards.

It'd be nice to not have a greyed out undo menu item.
http://hg.mozilla.org/mozilla-central/rev/11c3b74e18e7
Whiteboard: [scratchpad][fixed-in-fx-team][fixed-in-aurora] → [scratchpad][fixed-in-aurora]

Comment 15

6 years ago
Comment on attachment 540297 [details] [diff] [review]
[in-fx-team] [in-aurora] Easy change to enable Undo menuitem.

We'll take this on aurora and not beta.
Attachment #540297 - Flags: approval-mozilla-beta? → approval-mozilla-beta-

Updated

6 years ago
status-firefox7: --- → fixed
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Verified issue on: Win XP, Win 7, Ubuntu 11.04 and Mac OS X 10.6 following the STR from the Description - issue is no longer reproducible.

Setting resolution to VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.