653423 - Undo option is grayed out although action is applicable in Scratchpad

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[George Carstoiu]

Mozilla/5.0 (Windows NT 6.1; rv:6.0a1) Gecko/20110427 Firefox/6.0a1

Writing anything in the Workspaces window does not activate the Undo option from the Edit menu.

Reproducible: always

Steps to reproduce:
 1. Start Workspaces (F4)
 2. Write anything in the window
 3. Go to Edit->Undo

Actual results:
 - the Undo option is grayed out

Expected results:
 - after writing, the Undo button is active

Note:
 - although the button is not active, the shortcut can be used

Comment 1

[Erik Vold]

Attachment: revealing the workspace menu item

Comment 2

[Erik Vold]

(In reply to comment #1)
> Created attachment 529471 [details] [diff] [review] [review]
> revealing the workspace menu item

sorry this is meant for bug 654023 .. I'm not sure how to remove it..

Comment 3

[Rob Campbell [:rc] (:robcee)]

you can probably mark it obsolete and maybe change the patch name to something indicating "not what you want, go elsewhere".

Comment 4

[Teddy Ni]

Attachment: [in-fx-team] [in-aurora] Easy change to enable Undo menuitem.

Comment 5

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 540297 [details] [diff] [review]
[in-fx-team] [in-aurora] Easy change to enable Undo menuitem.

Nice!

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 540297 [details] [diff] [review]
[in-fx-team] [in-aurora] Easy change to enable Undo menuitem.

Would like to get this onto Aurora. It's a small polish fix.

Comment 7

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 529471 [details] [diff] [review]
revealing the workspace menu item

patch doesn't apply to this bug. Marking obsolete to hide it from the list.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 540297 [details] [diff] [review]
[in-fx-team] [in-aurora] Easy change to enable Undo menuitem.

The ID change seems spurious, can you omit it?

Comment 9

[Rob Campbell [:rc] (:robcee)]

Just found this bug in my list. Needs a checkin.

(In reply to comment #8)
> Comment on attachment 540297 [details] [diff] [review] [review]
> Easy change to enable Undo menuitem.
> 
> The ID change seems spurious, can you omit it?

I think that change was so the id would be more consistent with the rest of the menu items. I think we should keep it.

Comment 10

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 540297 [details] [diff] [review]
[in-fx-team] [in-aurora] Easy change to enable Undo menuitem.

http://hg.mozilla.org/integration/fx-team/rev/11c3b74e18e7

http://hg.mozilla.org/releases/mozilla-aurora/rev/e259c21107fb

Comment 11

[Rob Campbell [:rc] (:robcee)]

can we land this on beta too?

Comment 12

[LegNeato]

Does this have loc impact? Can add-ons be relying on that id? (likely not, but checking).

It is way, way late in the game to get it on beta...

Comment 13

[Rob Campbell [:rc] (:robcee)]

they can rely on it from beta onwards.

It'd be nice to not have a greyed out undo menu item.

Comment 14

[Tim Taubert [:ttaubert] (inactive)]

http://hg.mozilla.org/mozilla-central/rev/11c3b74e18e7

Comment 15

[LegNeato]

Comment on attachment 540297 [details] [diff] [review]
[in-fx-team] [in-aurora] Easy change to enable Undo menuitem.

We'll take this on aurora and not beta.

Comment 16

[Simona Badau, Desktop QA]

Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Verified issue on: Win XP, Win 7, Ubuntu 11.04 and Mac OS X 10.6 following the STR from the Description - issue is no longer reproducible.

Setting resolution to VERIFIED FIXED.