653464 - Cortext throw exception on properties without setter

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Alexandre Poirot [:ochameau]]

If we are using ES5 defineProperties on an object and we do not provide a setter, if we give such object to Cortex, we got this exception:
Trace:
    this._public = Cortex(this);
  File "resource://addon-kit-api-utils-lib/cortex.js", line 134, in Cortex
    Object.getOwnPropertyNames(object).forEach(function (name) {
  File "resource://addon-kit-api-utils-lib/cortex.js", line 136, in
    defineAlias(object, cortex, name);
  File "resource://addon-kit-api-utils-lib/cortex.js", line 104, in defineAlias
    createAliasProperty(source, name));
  File "resource://addon-kit-api-utils-lib/cortex.js", line 75, in createAliasPr
operty
    descriptor.set = property.set.bind(object);
TypeError: property.set is undefined


I faced this bug when I was working on bug 630962, I used a workaround this exception that will need to be removed. (widget.js:Model.setAttributes)

Comment 1

[Myk Melez [:myk] [@mykmelez]]

(automatic reprioritization of 1.0 bugs)

Comment 2

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/199

Pointer to Github pull-request

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Comment on attachment 542790 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/199

Dietrich can you take a look at this ?

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Thanks Dietrich!

https://github.com/mozilla/addon-sdk/commit/2522f642a8144a7a809581f1d3515474918c0d0c