Last Comment Bug 653564 - ContentParent.cpp:654:53: warning: comparison between signed and unsigned integer expressions
: ContentParent.cpp:654:53: warning: comparison between signed and unsigned int...
Status: RESOLVED FIXED
[build_warning]
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla6
Assigned To: Daniel Holbert [:dholbert]
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks: 633305
  Show dependency treegraph
 
Reported: 2011-04-28 14:25 PDT by Daniel Holbert [:dholbert]
Modified: 2011-04-29 17:12 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
trivial fix (1.09 KB, patch)
2011-04-28 14:27 PDT, Daniel Holbert [:dholbert]
doug.turner: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] 2011-04-28 14:25:22 PDT
Filing bug on this warning:

> dom/ipc/ContentParent.cpp: In member function 'void mozilla::dom::ContentParent::SetChildMemoryReporters(const InfallibleTArray<mozilla::dom::MemoryReport>&)':
> dom/ipc/ContentParent.cpp:654:53: warning: comparison between signed and unsigned integer expressions

Simple fix - we're iterating up to nsCOMArray::Count() (a signed value) using "PRUint32 i".

i just wants to be signed.
Comment 1 Daniel Holbert [:dholbert] 2011-04-28 14:27:19 PDT
Created attachment 528954 [details] [diff] [review]
trivial fix
Comment 2 Daniel Holbert [:dholbert] 2011-04-29 17:12:31 PDT
http://hg.mozilla.org/mozilla-central/rev/c45621e37aa8

Note You need to log in before you can comment on or make changes to this bug.