653669 - Undo a closed tab of an incompletely loaded page will close it

Status: RESOLVED DUPLICATE of bug 604463

(Firefox for Android Graveyard :: General, defect)

Description

[Cristian Nicolae (:xti)]

Steps to reproduce:
1. Open Fennec App
2. Open a new tab
3. Browse to http://planet.mozilla.org
4. Close the tab after 5 sec
5. Restore the closed tab

Expected result:
After step 5, the closed tab is restored and the webpage starts loading.

Actual result:
Taping on undo closed tab will close it, instead of restoring it.

Note:
Please see the following video: http://www.youtube.com/user/qaioana#p/a/u/0/N422-EeSwvM

Comment 1

[Cristian Nicolae (:xti)]

Build id : Mozilla/5.0 (Android;Linux armv7l;rv:6.0a1)Gecko/20110428
Firefox/6.0a1 Fennec/6.0a1
Device: Google Nexus S
OS: Android 2.3.1

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

This seems to happen if the page has not completed loading the basic DOM, and has not fired the DOMContentLoaded page.

I tested on desktop and it was almost impossible to reproduce this, but I could reproduce on my galaxy tab.

If the page was completely white with no content even partially loaded, we do not remember the page. If even a tiny bit of content is visible, the undo works fine.

I am hesitate to store the session info before we get any indication the the page has successfully loaded. DOMContentLoaded is the earliest browser event we can get. We could use webprogresslistener messages to try to get something earlier, but I don't know how important that is.

If you can see the webpage start to render, we should be able to undo.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

The patch in bug 604463 will make it even harder to close a tab before we save some part of it to session memory.