Closed
Bug 653718
Opened 15 years ago
Closed 15 years ago
incorrect struct size check in libnptest.so can cause overrun
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla6
People
(Reporter: mnemo, Assigned: mnemo)
Details
Attachments
(1 file)
|
1.62 KB,
patch
|
jaas
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Opera/9.80 (X11; Linux x86_64; U; en) Presto/2.8.131 Version/11.10
Build Identifier:
To joshmoz / dwitte;
When you added clearsitedata and urlredirectnotify, you forgot to update the struct size check in fillPluginFunctionTable() so now libnptest.so overwrites memory when loaded in browsers that don't support these funcs yet.
Look at the attached patch.
Reproducible: Always
Attachment #529086 -
Flags: review?(joshmoz)
Attachment #529086 -
Flags: review?(joshmoz) → review+
|
||
Comment 2•15 years ago
|
||
Keywords: checkin-needed
Whiteboard: [fixed-in-cedar]
|
|
||
Comment 3•15 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/c8c3e140ebe3
Martin, thanks for the patch!
Do we need to backport this to any branches?
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Whiteboard: [fixed-in-cedar]
Target Milestone: --- → mozilla6
|
|
||
Comment 4•15 years ago
|
||
Er, the right m-c changset is http://hg.mozilla.org/mozilla-central/rev/a2db30268958
|
||
Updated•3 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•