653736 - Fix the blamelist of a mobile try talos job so we can email the author the results (exception on test-master01)

Status: RESOLVED DUPLICATE of bug 655046

(Release Engineering :: General, defect, P4)

Description

[Armen [:armenzg]]

Currently test-master01 is throwing exceptions when it tries to send an email to the author.
The problem is that the author is "sendchange" rather than "user@domain" (the output below say --who sendchange).

This happens because the try mobile *talos* jobs do not set the property "who" like the desktop try test jobs.
The test mobile try jobs set the who property but they set it to "sendchange".

I think if we fix the blamelist we would not have this problem.

http://mxr.mozilla.org/build/source/buildbotcustom/bin/try_mailer.py#50
Where 'who' is set for the test factory:
http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#6800
I think it should be build.source.changes[0].who rather than build.source.changes[-1].who but I don't know!
http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#5171

2011-04-29 06:54:25-0700 [Broker,2810,10.250.48.152] sending mail (75795 bytes) to ['[e-mail]']
2011-04-29 06:54:25-0700 [Broker,2810,10.250.48.152] Starting factory <twisted.mail.smtp.ESMTPSenderFactory instance at 0x18b9072c>
2011-04-29 06:54:28-0700 [Broker,2810,10.250.48.152] Running ['/tools/buildbot-0.8.2/bin/python', '/tools/buildbotcustom/buildbotcustom/bin/log_uploader.py', 'stage.mozilla.org', '-u', 'ffxbld', '-i', '/home/cltbld/.ssh/ffxbld_dsa', '-b', 'mozilla-aurora', '-p', 'android', '/builds/buildbot/tests-master/mozilla-aurora_tegra_android_test-browser-chrome', '40']
2011-04-29 06:54:28-0700 [Broker,2785,10.250.48.154] Error running ['/tools/buildbot-0.8.2/bin/python', '/tools/buildbotcustom/buildbotcustom/bin/try_mailer.py', 'stage.mozilla.org', '-u', 'trybld', '-i', '/home/cltbld/.ssh/trybld_dsa', '-b', 'try', '-p', 'android', '-f', '[e-mail]', '--to-author', '--try', '/builds/buildbot/tests-master/try_tegra_android_test-mochitest-3', '49']
2011-04-29 06:54:28-0700 [Broker,2785,10.250.48.154] Log output: Running ['/tools/buildbot-0.8.2/bin/python', '/tools/buildbotcustom/buildbotcustom/bin/log_uploader.py', 'stage.mozilla.org', '-u', 'trybld', '-i', '/home/cltbld/.ssh/trybld_dsa', '-b', 'try', '-p', 'android', '--try', '/builds/buildbot/tests-master/try_tegra_android_test-mochitest-3', '49']
        Running post_upload.py -b try -p firefox --revision 1974491cd478 --who sendchange --builddir try-android --release-to-try-builds /tmp/tmp.roLgFm6378 /tmp/tmp.roLgFm6378/try_tegra_android_test-mochitest-3-build49.txt.gz
        http://stage.mozilla.org/pub/mozilla.org/firefox/try-builds/sendchange-1974491cd478/try-android/try_tegra_android_test-mochitest-3-build49.txt.gz

        From nobody Fri Apr 29 06:54:28 2011
        MIME-Version: 1.0
        Content-Type: text/html
        Date: Fri, 29 Apr 2011 06:54:28 -0700
        Subject: Try submission 1974491cd478
        From: [e-mail]
        To: sendchange
        References: <try-1974491cd478>
        In-Reply-To: <try-1974491cd478>

        Your Try Server test (1974491cd478) was successfully completed on builder try_tegra_android_test-mochitest-3.<br>
        <br>
        Summary of test results:<br>
        <br>
         mochitest-plain (dom/tests/mochitest/dom-level1-core)<br/>772/0/263<br>
        <br>
        <br>
        The full log for this test run is available at <a href="http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/sendchange-1974491cd478/try-android/try_tegra_android_test-mochitest-3-build49.txt.gz">http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/sendchange-1974491cd478/try-android/try_tegra_android_test-mochitest-3-build49.txt.gz</a>.<br>

        Traceback (most recent call last):
          File "/tools/buildbotcustom/buildbotcustom/bin/try_mailer.py", line 180, in <module>
            s.sendmail(options.from_, options.to, msg.as_string())
          File "/tools/python-2.6.5/lib/python2.6/smtplib.py", line 709, in sendmail
            raise SMTPRecipientsRefused(senderrs)
        smtplib.SMTPRecipientsRefused: {u'sendchange': (550, '5.1.1 <sendchange>... User unknown')}

2011-04-29 06:54:28-0700 [Broker,2785,10.250.48.154] Unhandled Error
        Traceback (most recent call last):
          File "/tools/python-2.6.5/lib/python2.6/threading.py", line 484, in run
            self.__target(*self.__args, **self.__kwargs)
          File "/tools/buildbot-0.8.2/lib/python2.6/site-packages/twisted/python/threadpool.py", line 207, in _worker
            result = context.call(ctx, function, *args, **kwargs)
          File "/tools/buildbot-0.8.2/lib/python2.6/site-packages/twisted/python/context.py", line 59, in callWithContext
          File "/tools/buildbot-0.8.2/lib/python2.6/site-packages/twisted/python/context.py", line 37, in callWithContext
            return func(*args,**kw)
        --- <exception caught here> ---
          File "/tools/buildbotcustom/buildbotcustom/status/log_handlers.py", line 88, in handleLogs
          File "/tools/python-2.6.5/lib/python2.6/subprocess.py", line 498, in check_call
            raise CalledProcessError(retcode, cmd)
        subprocess.CalledProcessError: Command '['/tools/buildbot-0.8.2/bin/python', '/tools/buildbotcustom/buildbotcustom/bin/try_mailer.py', 'stage.mozilla.org', '-u', 'trybld', '-i', '/home/cltbld/.ssh/trybld_dsa', '-b', 'try', '-p', 'android', '-f', '[e-mail]', '--to-author', '--try', '/builds/buildbot/tests-master/try_tegra_android_test-mochitest-3', '49']' returned non-zero exit status 1

Comment 2

[Aki Sasaki (not active)]

I'm going to investigate this while working on bug 655046.

Comment 3

[Aki Sasaki (not active)]

Patch to fix is in bug 655046; marking dup.