653743 - Search button is too small

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Aki Laaksovirta]

User-Agent:       Mozilla/5.0 (X11; Linux i686 on x86_64; rv:2.0.2pre) Gecko/20110428 Firefox/4.0.2pre SeaMonkey/2.1pre
Build Identifier: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:2.0.2pre) Gecko/20110428 Firefox/4.0.2pre SeaMonkey/2.1pre

The search button in the main browser toolbar can hardly be seen when "Show" is set to "Icons" only.

Reproducible: Always

Steps to Reproduce:
1. Right-click on the Navigation Toolbar.
2. Open the Customize Toolbar window.
3. Select "Icons" from the Show: menu.

Actual Results:  
The Search button transforms into a zero-width button with borders being the only visible part.

Expected Results:  
The Search button should retain the text even in the "Icons" mode, just like the Go button does.

Comment 1

[Philip Chee]

Works for me:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0.2pre) Gecko/20110420 Firefox/4.0.2pre SeaMonkey/2.1pre

You should see a "magnifying glass icon". If you switch to icons+text you should see both the text "Search" and the magnifying glass icon.

Please make sure you are testing with the built in themes (SeaMonkey Default Theme or the SeaMonkey Modern Theme).

Comment 2

[Aki Laaksovirta]

I have tested this with both of the built-in themes. Any kind of magnifying glass icon is not visible. I know what you mean by it. Should I add a screenshot as an attachment?

Comment 3

[Philip Chee]

In classic, type this (or copypaste) into the URL bar:
chrome://communicator/skin/icons/search.png
In modern:
chrome://global/skin/icons/search.gif
Do you see the magnifying glass in the browser content area?

Do you have some funky css in your userChrome.css?

Does the problem occur in SeaMonkey's Safe Mode?
<http://kb.mozillazine.org/Safe_mode#Linux>

Comment 4

[alecscottaz]

The bug is reproducable on stock SeaMonkey 2.1pre

The build has the classic theme icon but not the modern icon when using the classic theme and the reverse is true when running the modern theme.

There is no custom css and the icon is still missing in safe mode.

Comment 5

[Philip Chee]

Neil, you're our theme expert. Any Ideas?

Comment 6

[Philip Chee]

Issue confirmed by nekoCAT and Zart from #seamonkey.

Comment 7

[Konstantin Zemlyak]

Attachment: Screenshot of "Search" button on toolbar in icons only mode. SM nightly on Linux x64.

Comment 8

[Konstantin Zemlyak]

Icon is not shown due to rule in chrome://global/content/xul.css:135 that does display:none. It's commented as "detection of system setting to use icons in buttons".
So after enabling /desktop/gnome/interface/buttons_have_icons in gconf-editor and restarting SM icon was shown on the "Search" button as it should.

Comment 9

[[e-mail]]

Looks like we'll need to provide an override for the search button just in case (we can't test the system metric inside Modern because it returns false on other platforms so it's only usable inside platform-specific ifdefs.)

Comment 10

[Philip Chee]

Can someone try the following userChrome.css:

button[label]:not([label=""]) > .button-box > .button-icon:not(:-moz-system-metric(images-in-buttons)),
button[label]:not([label=""]) > .button-box > .box-inherit > .button-icon:not(:-moz-system-metric(images-in-buttons)) {
  display: -moz-box !important;
}
with /desktop/gnome/interface/buttons_have_icons disabled in gconf-editor?

Comment 11

[[e-mail]]

Attachment: Possible patch

Comment 12

[Philip Chee]

Scratch that:

In userChrome try:

toolbar[mode="icons"] #search-button > .button-box > .button-icon {
  display: -moz-box !important;
}

Comment 13

[Konstantin Zemlyak]

c12 works.

Comment 14

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 529687 [details] [diff] [review]
Possible patch

I cannot reproduce the problem so I cannot test it. :-( The patch looks good but I cannot blindly give it r+ so I'm afraid you have to find someone else to at least reproduce it and verify that the patch makes a difference (basically an f+). Feel free to re-request then.

My Linux VM runs Kubuntu Maverick (10.10, x86). Both gconf-tool and gconf-editor show that /desktop/gnome/interface/buttons_have_icons is false. Toggling to true and back to false made no difference (again tried both tools). The icon shows with or without the patch (toolbar set to "Icons"). I tried with JWM and rxvt instead of KDE and Konsole, no difference. I see the rule in xul.css so the GTK2 ifdef was processed but I cannot get the rule to apply (checked DOMI/CSS).

NB: If this requires a full Gnome setup then I fear I'm the wrong person to ask.

Comment 15

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux x86_64; rv:6.0a1) Gecko/20110417 Firefox/6.0a1 SeaMonkey/2.2a1pre ID:20110417003006

Tested with either the rule in comment #10 or that in comment #12, with and without the following, which is normally present in my userChrome.css

[id$=button]
  /* anything whose ID ends in "button" */
  { border-style:       outset                  !important
  ; border-width:       1px                     !important
  }
[id$=button]:active
  { border-style:       inset                   !important
  }

and in all three of SeaMonkey Default, SeaMonkey Modern, and EarlyBlue (my usual) themes, as well as in Safe Mode (which forces Default and disables userChrome.css). Only in Safe Mode is the bug visible. (Modern has other problems but not that one.)

Comment 16

[Philip Chee]

Attachment: patched modern navigator.css

Comment 17

[Philip Chee]

Attachment: Patched classic navigator.css

Comment 18

[Tony Mechelynck [:tonymec]]

In reply to comment #16 and #17
Tested in today's nightly after replacing navigator.css in both Classic and Modern, in an "almost" fresh profile (used only a couple of times for testing, but by far not as extensively customized as my usual). Search button icon is visible in both cases, and also in Safe Mode (expected since part of "out of the box" browser) => f+ to both.

Comment 19

[Tony Mechelynck [:tonymec]]

In reply to comment #18
P.S. even after setting the "Settings for this toolbar" to "Icons".

Comment 20

[Philip Chee]

Comment on attachment 529687 [details] [diff] [review]
Possible patch

rs=me based on testing by tonymec.

Comment 21

[Philip Chee]

Please check this in Neil.

Comment 22

[[e-mail]]

Pushed changeset 4b3fcf807612 to comm-central.

Pushed changeset b6b190e2d797 to releases/comm-2.0