improve management of plugin MIME types, MIME descriptions, and extensions

RESOLVED FIXED

Status

()

Core
Plug-ins
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

Trunk
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Assignee)

Description

6 years ago
Created attachment 529157 [details] [diff] [review]
fix v1.0

We should improve management of plugin MIME types, MIME descriptions, and extensions. The array management is error prone.
(Assignee)

Comment 1

6 years ago
Created attachment 529173 [details] [diff] [review]
fix v1.1
Attachment #529157 - Attachment is obsolete: true
(Assignee)

Comment 2

6 years ago
Created attachment 529177 [details] [diff] [review]
fix v1.2
(Assignee)

Comment 3

6 years ago
Comment on attachment 529177 [details] [diff] [review]
fix v1.2

This makes our MIME mgmt code more efficient, consistent, and a lot easier to read/understand.
Attachment #529177 - Attachment is patch: true
Attachment #529177 - Attachment mime type: text/x-patch → text/plain
Attachment #529177 - Flags: review?(benjamin)
(Assignee)

Comment 4

6 years ago
It also has some fixes for MIME information potentially getting out of sync (type vs. descriptions vs. extensions).
(Assignee)

Updated

6 years ago
Attachment #529173 - Attachment is obsolete: true
Attachment #529177 - Flags: review?(benjamin) → review+
(Assignee)

Comment 5

6 years ago
Created attachment 530924 [details] [diff] [review]
fix v1.3

Build fixes.
(Assignee)

Comment 6

6 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/6824e96ca32a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
I don't have a hard regression range, but the latest m-c win32 hourly with this patch hangs on startup.  Disabling OOPP allows the browser to start. 

Possible this patch has broken plugin-container on windows ?
(Assignee)

Comment 8

6 years ago
Anything is possible but tests pass and I ran it locally with no problems. Keep us updated with any new information. Maybe post some more details about your system in an attached text file, including installed browser plugins (about:plugins) and your OS version.
Well at the moment I'm at work, and won't get to find a true regress-range till sometime tomorrow.

system is Win7 x64 running on AMD Phenom II Quad 8 gig ram
plugins are all up to date with the latest Flash version.

Using the win32 m-c hourly build with your cset from here:
http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-central-win32/1305037440/

The hourly before this one, or perhaps two before this one is OK, so its either this patch or the patch-set that re-landed all the stuff backed out yesterday:
http://hg.mozilla.org/mozilla-central/rev/8d378453a8ac

I'm pretty sure that cset is OK, but as I said - I'm not at my machine right-now.
Neither the 32 bit zip build from http://hg.mozilla.org/mozilla-central/rev/6824e96ca32a nor the 32 bit zip build from the prior push http://hg.mozilla.org/mozilla-central/rev/83ca7e971857 is hanging on startup for me with a clean profile on Win7x64.
(In reply to comment #10)
> Neither the 32 bit zip build from
> http://hg.mozilla.org/mozilla-central/rev/6824e96ca32a nor the 32 bit zip
> build from the prior push
> http://hg.mozilla.org/mozilla-central/rev/83ca7e971857 is hanging on startup
> for me with a clean profile on Win7x64.

Even if you open a page with flash on it ?
(In reply to comment #11)
> Even if you open a page with flash on it ?

Watched a youtube video. Pretty sure it was Flash, lemme try again.
You need to log in before you can comment on or make changes to this bug.