653958 - aBrowser.contentDocument.getElementById("textbox") is null

Status: RESOLVED DUPLICATE of bug 739805

(Firefox :: Session Restore, defect)

Description

[ithinc]

User-Agent:       Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110430 Firefox/6.0a1
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110430 Firefox/6.0a1

Error: '[JavaScript Error: "aBrowser.contentDocument.getElementById("textbox") is null" {file: "resource://gre/components/nsSessionStore.js" line: 1901}]' when calling method: [nsISessionStore::getTabState] = NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS


Reproducible: Always

Steps to Reproduce:
1. Open an "about:config" tab
2. Set "browser.sessionstore.max_concurrent_tabs" to 0
3. Switch to another tab and restart Firefox
4. After startup, getTabState of the unloaded "about:config" tab

Comment 1

[u279076]

Unable to reproduce with:
Mozilla/5.0 (Windows NT 5.1; rv:6.0a1) Gecko/20110510 Firefox/6.0a1

Please update and test with a new profile.

Comment 2

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

That's interesting because we shouldn't be looking at the document - we should be looking at the cached data.

Comment 3

[Paul O'Shannessy [:zpao] (not bugmail, email directly)]

I looked a little more closely (actually followed the STR) and yep, that happens. We're explicitly trying to look at that textbox even if that page hasn't been restored: https://hg.mozilla.org/mozilla-central/file/794c73cbfca6/browser/components/sessionstore/src/nsSessionStore.js#l1915

We should probably just not call _updateTextAndScrollDataForTab for tabs which aren't restored.

Comment 4

[ithinc]

It seems fixed by Bug 739805.

Last good nightly: 2012-03-29
First bad nightly: 2012-03-30

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1965a2c89d61&tochange=92fe907ddac8

Comment 5

[u279076]

Thanks ithinc, can you please confirm that Firefox 15 does not have this bug?
ftp://ftp.mozilla.org/pub/firefox/releases/15.0/