Closed
Bug 653959
Opened 14 years ago
Closed 14 years ago
warning C4273: 'js_DeclEnvClass' : inconsistent dll linkage
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: RyanVM, Unassigned)
References
Details
(Whiteboard: [build_warning][fixed-in-tracemonkey])
Attachments
(1 file)
|
751 bytes,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
dist\include\jsfun.h(299) : warning C4273: 'js_DeclEnvClass' : inconsistent dll linkage
dist\include\jsobj.h(1695) : see previous definition of 'js_DeclEnvClass'
In jsfun.h, the define is:
extern js::Class js_DeclEnvClass;
In jsobj.h, it was declared in bug 634590 as:
extern JS_FRIEND_DATA(js::Class) js_DeclEnvClass;
|
Reporter | |
Updated•14 years ago
|
Whiteboard: [build_warning]
|
|
Reporter | |
Comment 1•14 years ago
|
||
Attachment #529398 -
Flags: review?(brendan)
|
|
Reporter | |
Comment 2•14 years ago
|
||
Comment on attachment 529398 [details] [diff] [review]
Fix
Luke, Brendan's tied up right now. Can you review?
Attachment #529398 -
Flags: review?(brendan) → review?(luke)
|
||
Updated•14 years ago
|
Attachment #529398 -
Flags: review?(luke) → review+
|
|
Reporter | |
Updated•14 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 3•14 years ago
|
||
I don't have commit access, so I'll need some help getting this checked into tm.
|
||
Updated•14 years ago
|
Keywords: checkin-needed
Whiteboard: [build_warning] → [build_warning][fixed in tracemonkey]
|
||
Comment 4•14 years ago
|
||
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/3a6b0d5e35be
Note: not marking as fixed because fixed-in-tracemonkey is not present on the whiteboard.
|
||
Updated•14 years ago
|
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [build_warning][fixed in tracemonkey] → [build_warning][fixed-in-tracemonkey]
You need to log in
before you can comment on or make changes to this bug.
Description
•