The default bug view has changed. See this FAQ.

warning C4273: 'js_DeclEnvClass' : inconsistent dll linkage

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: RyanVM, Unassigned)

Tracking

Trunk
x86
Windows 7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning][fixed-in-tracemonkey])

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
dist\include\jsfun.h(299) : warning C4273: 'js_DeclEnvClass' : inconsistent dll linkage
        dist\include\jsobj.h(1695) : see previous definition of 'js_DeclEnvClass'

In jsfun.h, the define is:
extern js::Class js_DeclEnvClass;

In jsobj.h, it was declared in bug 634590 as:
extern JS_FRIEND_DATA(js::Class) js_DeclEnvClass;
(Reporter)

Updated

6 years ago
Whiteboard: [build_warning]
(Reporter)

Comment 1

6 years ago
Created attachment 529398 [details] [diff] [review]
Fix
Attachment #529398 - Flags: review?(brendan)
(Reporter)

Comment 2

6 years ago
Comment on attachment 529398 [details] [diff] [review]
Fix

Luke, Brendan's tied up right now. Can you review?
Attachment #529398 - Flags: review?(brendan) → review?(luke)

Updated

6 years ago
Attachment #529398 - Flags: review?(luke) → review+
(Reporter)

Updated

6 years ago
Keywords: checkin-needed
(Reporter)

Comment 3

6 years ago
I don't have commit access, so I'll need some help getting this checked into tm.
Keywords: checkin-needed
Whiteboard: [build_warning] → [build_warning][fixed in tracemonkey]
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/3a6b0d5e35be
Note: not marking as fixed because fixed-in-tracemonkey is not present on the whiteboard.

Updated

6 years ago
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [build_warning][fixed in tracemonkey] → [build_warning][fixed-in-tracemonkey]
Blocks: 671947
You need to log in before you can comment on or make changes to this bug.