Closed Bug 654057 Opened 9 years ago Closed 9 years ago
Combining character doesn't work right in "Segoe UI" font
This worksforme (on Mac). Are you sure this isn't just an issue of the web page and the alert using different fonts and the font for the latter (or our handling of it) being broken in your case?
Yes, that may well be. I'm sorry I don't know how to confirm, just know that the default alert font isn't working--not sure that's something u can do anything about or not.
Hm. What hapens if you style your HTML with "font-family: sans-serif"?
HTML is still ok (and alert still not good). I forgot though that I was testing with a XUL-based HTML editor, and oddly, it is only in that environment that it appears incorrectly---in regular HTML loaded inside a regular browser tab, it shows correctly.
Does the alert you get in the editor look the same as the regular HTML one? Or is it a separate dialog instead of a tab-modal box?
What happens in HTML styled with "font: menu"?
OK, yeah. In the editor you're getting a modal dialog alert, not a tab-modal alert. And they use different font styles. Sounds like something is up with our interaction with your "menu" font. Any idea what font that is? ;)
Component: Layout → Layout: Text
QA Contact: layout → layout.fonts-and-text
Ok, the "winner" is: "Segoe UI" (Windows 7)
Summary: Combining character in alerts → Combining character doesn't work right in "Segoe UI" font
Ugh... I suspect this is a regression from bug 635639. We may have to try and make the patch there more selective in its effects.
Status: UNCONFIRMED → NEW
Ever confirmed: true
The problem here is that the patch for bug 635639 was not quite right (although simply reverting it wouldn't fix things, as that leaves a gap where the diacritic occurs due to its non-zero advance). In hb_ot_layout_position_finish(), it was incorrect to touch the diacritic's x_offset value, because at this stage GPOS::position_finish() has not yet been called. So all we need to do here is zero the advance width, and then let position_finish() do the proper attachment.
Assignee: nobody → jfkthame
Attachment #530252 - Flags: review?(jdaggett)
Comment on attachment 530268 [details] [diff] [review] reftest for diacritic in Segoe UI Might be nice to have a font that simply replicates the problem found in Segoe UI so that we would catch this on all platforms. But I'll let you judge whether that's worth the effort or not.
Attachment #530268 - Flags: review?(jdaggett) → review+
http://hg.mozilla.org/mozilla-central/rev/800a2d46bb4e (patch) http://hg.mozilla.org/mozilla-central/rev/427fa3603d4c (testcase) We could create a custom font that replicates the problem, but I don't see it as a high priority right now; as long as we're running tests on Win7, at least, we'll know if we regress this (e.g. when taking a harfbuzz update). If we happen to run across a free font that exhibits the same issue, we could add that to the testcase.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.