Last Comment Bug 654063 - nsIPlatformCharset on Android should return "UTF-8"
: nsIPlatformCharset on Android should return "UTF-8"
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Internationalization (show other bugs)
: Trunk
: All Android
: -- normal (vote)
: mozilla7
Assigned To: Makoto Kato [:m_kato]
:
Mentors:
http://developer.android.com/referenc...
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-02 01:40 PDT by Makoto Kato [:m_kato]
Modified: 2011-05-26 23:53 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (3.43 KB, patch)
2011-05-15 18:48 PDT, Makoto Kato [:m_kato]
smontagu: review+
Details | Diff | Splinter Review

Description Makoto Kato [:m_kato] 2011-05-02 01:40:50 PDT
The default character set on Android is UTF-8.  nsIPlatformCharset should return UTF-8 simply.
Comment 1 Makoto Kato [:m_kato] 2011-05-15 18:48:56 PDT
Created attachment 532551 [details] [diff] [review]
fix
Comment 2 Simon Montagu :smontagu 2011-05-23 02:27:52 PDT
Comment on attachment 532551 [details] [diff] [review]
fix

r=me, but I wonder if maybe it's time to just do this for nsUnixCharset.cpp as well.
Comment 3 Makoto Kato [:m_kato] 2011-05-26 19:08:16 PDT
(In reply to comment #2)
> Comment on attachment 532551 [details] [diff] [review] [review]
> fix
> 
> r=me, but I wonder if maybe it's time to just do this for nsUnixCharset.cpp
> as well.

Now, most Linux distribution and the latest version of UNIX (AIX and Solaris) are UTF8 as default platform charset, but it can change it to something such as Shift_JIS by user.   So we should not do it now.

But, if we only support UTF-8 as system charset of POSIX platform by Firefox.next (Thunderbird and SeaMonkey), it can use UTF-8 only version of nsIPlatformCharset.
Comment 4 Makoto Kato [:m_kato] 2011-05-26 23:53:52 PDT
http://hg.mozilla.org/mozilla-central/rev/1b15458d3ca7

Note You need to log in before you can comment on or make changes to this bug.