Created attachment 529446 [details] [diff] [review] Display which GLIBCXX symbols cause an error In bug 643690, I added an error displaying GLIBCXX versions we don't want to link against. It would be more useful to also list which symbols correspond to these versions. (Note that I used > /dev/null instead of grep -q because I don't know if we can rely on grep providing the -q option)
Attachment #529446 - Flags: review?(ted.mielczarek)
While at it, "Error" in the message doesn't seem to trigger anything on tinderbox logs :-/ http://tinderbox.mozilla.org/showlog.cgi?log=Try/1304659221.1304663419.6828.gz Does it need to be on stderr or something?
Does that mean we need TinderboxPrint *and* Error to be displayed on tbpl?
No. TinderboxPrint is what makes things show up in the build column on tinderbox.mozilla.org. The error parser controls what shows up in the summary of the short log: http://mxr.mozilla.org/mozilla/source/webtools/tinderbox/ep_unittest.pl
So, we need to abuse one of these: http://mxr.mozilla.org/mozilla/source/webtools/tinderbox/ep_unittest.pl#27 Or should we add a generic type of error there ?
I'd just print TEST-UNEXPECTED-FAIL, honestly, since this is in "make check". I think we don't match "Error:" because we get too many false positives from tests that have expected JS Errors or print that string in the test text, etc.
fair enough, though it's not in make check, but in plain make.
Comment on attachment 529446 [details] [diff] [review] Display which GLIBCXX symbols cause an error Review of attachment 529446 [details] [diff] [review]: ----------------------------------------------------------------- r=me with the output fixed to match the tinderbox error parser.
Attachment #529446 - Flags: review?(ted.mielczarek) → review+
http://hg.mozilla.org/mozilla-central/rev/d21dae3474b3 (the new attachment was the patch as landed)
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.