654087 - Elfhack error

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Bengt-Erik Soderstrom]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:6.0a1) Gecko/20110501 Firefox/6.0a1 SeaMonkey/2.2a1pre
Build Identifier: Nightly 6.0a1  2011-05-02  

Trying to build with elfhack rresults in this:

== If you get failures below, please file a bug describing the error
=== and your environment (compiler and linker versions), and use
=== --disable-elf-hack until this is fixed.
===
cd ../../dist/bin; find . -name "*.so" | xargs ../../build/unix/elfhack/elfhack
elfhack: /home/bengt-erik/mozilla-central/src/build/unix/elfhack/elf.cpp:286: Elf::Elf(std::ifstream&): Assertion `segment->getMemSize() == phdr.p_memsz' failed.
xargs: ../../build/unix/elfhack/elfhack: avslutades av signal 6 (terminated by signal 6)
make[2]: *** [elfhack] Fel 125 (Error  125)

Building as such is OK, this happens when using 'make package'

Compiler: gcc 4.5.2  (Ubuntu 11.04)
Linker  : GNU gold (GNU Binutils 2.21.51.20110227) 1.11

when using --disable-elf-hack everything is OK


Reproducible: Always

Comment 1

[Juan Simón]

I have same problem compiling Firefox 7.0.1 with PGO.
I don't understand that if it disables the elfhack when I configure/compile, why it fails when I try to install it with "sudo make -f client.mk install" because this?

Comment 2

[Sanjito Kurniawan]

Same problem here compiling FF 7.0.1 with PGO
Tried the --disable-elf-hack, but this elf-hack makes icc to lose its compatibility to compile as what ./configure said

Comment 3

[Nathan Froyd [:froydnj]]

I am seeing this same bug when compiling with PGO.  The problem looks like that we have a .tbss section of 16x + 8 bytes and the TLS segment that contains it has a memsz of 16(x+1) bytes.  Both section and segment are said to be 16-byte aligned.  Will upload an example file in a second.

Comment 4

[Nathan Froyd [:froydnj]]

Attachment: failing library

An x86-64 shared library that exhibits the problem.  Compiled with close-to-tip GCC 4.7 and linked with trunk gold.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

this affects me as well, not sure what other information is needed.

Comment 6

[Mike Hommey [:glandium]]

(In reply to Joel Maher (:jmaher) from comment #5)
> this affects me as well, not sure what other information is needed.

If your problem is http://pastebin.mozilla.org/1412669 that would be a separate issue. Please file a new bug with that log, as well as a copy of the file on which elfhack segfaults (apparently, libplugin-container.so)

Comment 7

[Mike Hommey [:glandium]]

Attachment: Don't error out on gold special treatment of PT_TLS segment memsize

Comment 9

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/eb1363fb8a2d

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/eb1363fb8a2d