Closed Bug 654088 Opened 9 years ago Closed 9 years ago

Update ignore_dirs according to the slavebuilddir

Categories

(Release Engineering :: General, defect, P3)

x86
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

(Whiteboard: [automation][simple])

Attachments

(1 file, 1 obsolete file)

Attached patch buildbotcustom (obsolete) — Splinter Review
Looks like ignore_dirs should be upadted according to the slavebuilddirs (which use reallyShort) in some places.

Not tested patch.
Assignee: nobody → rail
Priority: -- → P3
Comment on attachment 529454 [details] [diff] [review]
buildbotcustom

Patch looks good, assuming it survives staging.
Attachment #529454 - Flags: feedback+
The patch didn't work due to circular imports (buildbotcustom.process.factory is imported by buildbotcustom.misc). Need to move reallyShort to buildbotcustom.common(?) and update the consumers.
I moved reallyShort from misc to common to prevent circular imports. No need to reload buildbotcustom.common because it's already reloaded from factory.py.

The patch passes test-masters.sh.
Attachment #529454 - Attachment is obsolete: true
Attachment #543907 - Flags: review?(coop)
Attachment #543907 - Flags: review?(coop) → review+
Comment on attachment 543907 [details] [diff] [review]
move reallyShort to buildbotcustom.common

http://hg.mozilla.org/build/buildbotcustom/rev/8fe40c8c276b
Attachment #543907 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.