Last Comment Bug 654117 - libXt library is not needed for Qt firefox
: libXt library is not needed for Qt firefox
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Widget: Qt (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: mozilla7
Assigned To: Oleg Romashin (:romaxa)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-05-02 08:34 PDT by Oleg Romashin (:romaxa)
Modified: 2011-06-09 12:19 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Safe removal for XT linking in Qt build (633 bytes, patch)
2011-05-30 11:50 PDT, Oleg Romashin (:romaxa)
no flags Details | Diff | Review
removal for XT linking in Qt build (590 bytes, patch)
2011-06-02 09:54 PDT, Oleg Romashin (:romaxa)
ted: review+
Details | Diff | Review

Description Oleg Romashin (:romaxa) 2011-05-02 08:34:22 PDT
Just recently found that libXt configure check is hardcoded for X11 platforms, but not really used in Qt configuration.

I think we should make it GTK only
Comment 1 Oleg Romashin (:romaxa) 2011-05-30 11:50:11 PDT
Created attachment 536136 [details] [diff] [review]
Safe removal for XT linking in Qt build

Full disable of xt library is quite difficult, bunch of places gets broken if I disable Xt checking... but we can just remove it from final LD flags
Comment 2 Oleg Romashin (:romaxa) 2011-06-02 09:54:10 PDT
Created attachment 536909 [details] [diff] [review]
removal for XT linking in Qt build

Ups, previous patch was changing gtk build instead of Qt, sorry.
Comment 3 Ted Mielczarek [:ted.mielczarek] 2011-06-08 10:45:12 PDT
Comment on attachment 536909 [details] [diff] [review]
removal for XT linking in Qt build

Review of attachment 536909 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 4 Daniel Holbert [:dholbert] 2011-06-09 12:14:33 PDT
http://hg.mozilla.org/mozilla-central/rev/5cc60351be1a

Note You need to log in before you can comment on or make changes to this bug.