libXt library is not needed for Qt firefox

RESOLVED FIXED in mozilla7

Status

Core Graveyard
Widget: Qt
RESOLVED FIXED
6 years ago
11 months ago

People

(Reporter: romaxa, Assigned: romaxa)

Tracking

Trunk
mozilla7
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Just recently found that libXt configure check is hardcoded for X11 platforms, but not really used in Qt configuration.

I think we should make it GTK only
(Assignee)

Comment 1

6 years ago
Created attachment 536136 [details] [diff] [review]
Safe removal for XT linking in Qt build

Full disable of xt library is quite difficult, bunch of places gets broken if I disable Xt checking... but we can just remove it from final LD flags
Assignee: nobody → romaxa
Attachment #536136 - Flags: feedback?(ted.mielczarek)
(Assignee)

Comment 2

6 years ago
Created attachment 536909 [details] [diff] [review]
removal for XT linking in Qt build

Ups, previous patch was changing gtk build instead of Qt, sorry.
Attachment #536136 - Attachment is obsolete: true
Attachment #536136 - Flags: feedback?(ted.mielczarek)
Attachment #536909 - Flags: review?(ted.mielczarek)
Comment on attachment 536909 [details] [diff] [review]
removal for XT linking in Qt build

Review of attachment 536909 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #536909 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/5cc60351be1a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Version: unspecified → Trunk
Target Milestone: --- → mozilla7
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.