Types.h:91:9: warning: C++ style comments are not allowed in ISO C90 (also for Util.h:77:9)

RESOLVED FIXED

Status

()

Core
MFBT
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning], URL)

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
This cset
  http://hg.mozilla.org/mozilla-central/rev/3dd6ec45084c
which just landed as part of a tracemonkey merge introduced 22 instances of warnings like this:
{
In file included from ../../dist/include/mozilla/Util.h:43:0,
                 from ../../dist/include/jsutil.h:48,
                 from /builds/slave/cen-lnx64-dbg/build/js/jsd/jsd.h:78,
                 from /builds/slave/cen-lnx64-dbg/build/js/jsd/jsd_atom.c:42:
../../dist/include/mozilla/Types.h:91:9: warning: C++ style comments are not allowed in ISO C90
../../dist/include/mozilla/Types.h:91:9: warning: (this will be reported only once per input file)
}

This needs some "//" --> "/**/" love.
(Assignee)

Updated

6 years ago
Blocks: 642381
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [build_warning]
(Assignee)

Comment 1

6 years ago
Created attachment 529616 [details] [diff] [review]
fix
Attachment #529616 - Flags: review?(jones.chris.g)
(Assignee)

Updated

6 years ago
Attachment #529616 - Flags: review?(jones.chris.g) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/mozilla-central/rev/66cff9a9d5d2
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Summary: Types.h:91:9: warning: C++ style comments are not allowed in ISO C9 (also for Util.h:77:9) → Types.h:91:9: warning: C++ style comments are not allowed in ISO C90 (also for Util.h:77:9)
Component: General → MFBT
QA Contact: general → mfbt
You need to log in before you can comment on or make changes to this bug.