Last Comment Bug 654346 - Types.h:91:9: warning: C++ style comments are not allowed in ISO C90 (also for Util.h:77:9)
: Types.h:91:9: warning: C++ style comments are not allowed in ISO C90 (also f...
Status: RESOLVED FIXED
[build_warning]
:
Product: Core
Classification: Components
Component: MFBT (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Daniel Holbert [:dholbert]
:
:
Mentors:
http://tinderbox.mozilla.org/showlog....
Depends on:
Blocks: 642381
  Show dependency treegraph
 
Reported: 2011-05-02 17:58 PDT by Daniel Holbert [:dholbert]
Modified: 2011-12-17 23:21 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (1.03 KB, patch)
2011-05-02 18:01 PDT, Daniel Holbert [:dholbert]
cjones.bugs: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] 2011-05-02 17:58:45 PDT
This cset
  http://hg.mozilla.org/mozilla-central/rev/3dd6ec45084c
which just landed as part of a tracemonkey merge introduced 22 instances of warnings like this:
{
In file included from ../../dist/include/mozilla/Util.h:43:0,
                 from ../../dist/include/jsutil.h:48,
                 from /builds/slave/cen-lnx64-dbg/build/js/jsd/jsd.h:78,
                 from /builds/slave/cen-lnx64-dbg/build/js/jsd/jsd_atom.c:42:
../../dist/include/mozilla/Types.h:91:9: warning: C++ style comments are not allowed in ISO C90
../../dist/include/mozilla/Types.h:91:9: warning: (this will be reported only once per input file)
}

This needs some "//" --> "/**/" love.
Comment 1 Daniel Holbert [:dholbert] 2011-05-02 18:01:42 PDT
Created attachment 529616 [details] [diff] [review]
fix
Comment 2 Daniel Holbert [:dholbert] 2011-05-03 10:25:22 PDT
http://hg.mozilla.org/mozilla-central/rev/66cff9a9d5d2

Note You need to log in before you can comment on or make changes to this bug.