Closed Bug 654346 Opened 13 years ago Closed 13 years ago

Types.h:91:9: warning: C++ style comments are not allowed in ISO C90 (also for Util.h:77:9)

Categories

(Core :: MFBT, defect)

Product:
Core
Component:
MFBT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: dholbert, Assigned: dholbert)

References

(
URL
)

Details

(Whiteboard: [build_warning])

Attachments

(1 file)

fix
1.03 KB, patch
cjones
: review+
Details | Diff | Splinter Review 
This cset
  http://hg.mozilla.org/mozilla-central/rev/3dd6ec45084c
which just landed as part of a tracemonkey merge introduced 22 instances of warnings like this:
{
In file included from ../../dist/include/mozilla/Util.h:43:0,
                 from ../../dist/include/jsutil.h:48,
                 from /builds/slave/cen-lnx64-dbg/build/js/jsd/jsd.h:78,
                 from /builds/slave/cen-lnx64-dbg/build/js/jsd/jsd_atom.c:42:
../../dist/include/mozilla/Types.h:91:9: warning: C++ style comments are not allowed in ISO C90
../../dist/include/mozilla/Types.h:91:9: warning: (this will be reported only once per input file)
}

This needs some "//" --> "/**/" love.
Blocks: 642381
OS: Linux → All
Hardware: x86_64 → All
Whiteboard: [build_warning]
Attached patch fix — — Splinter Review 

        Attachment #529616 -
        Flags: review?(jones.chris.g)

        Attachment #529616 -
        Flags: review?(jones.chris.g) → review+

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/66cff9a9d5d2
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED

    
  
Summary: Types.h:91:9: warning: C++ style comments are not allowed in ISO C9  (also for Util.h:77:9) → Types.h:91:9: warning: C++ style comments are not allowed in ISO C90  (also for Util.h:77:9)

    
  
Component: General → MFBT
QA Contact: general → mfbt

          You need to log in
          before you can comment on or make changes to this bug.