The default bug view has changed. See this FAQ.

nsOggReader.cpp:1065:18: warning: unused variable ‘range’

RESOLVED FIXED in mozilla6

Status

()

Core
Audio/Video
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Unassigned)

Tracking

Trunk
mozilla6
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

(Reporter)

Description

6 years ago
Filing bug on this build warning:

> nsOggReader.cpp: In member function ‘nsresult nsOggReader::GetSeekRanges(nsTArray<nsOggReader::SeekRange>&)’:
> nsOggReader.cpp:1065:18: warning: unused variable ‘range’

This variable is just an alias for cached[index], but it looks like we never used the alias even in the cset that added it:
  http://hg.mozilla.org/mozilla-central/rev/d3aeb102da2b

cpearce, perhaps you intended to replace the "cached[index]" usages with the alias?  Or, should this variable just go away?
(Reporter)

Comment 1

6 years ago
Here's the link to the flagged line in MXR, for reference:
http://mxr.mozilla.org/mozilla-central/source/content/media/ogg/nsOggReader.cpp#1065
Thanks, I've got a fix for this included in my patch in bug 650994.
Depends on: 650994
Fixed by landing of bug 650994.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla6
You need to log in before you can comment on or make changes to this bug.