654393 - TI: Assertion failure: v.isBoolean(), at js/src/jsbool.cpp:202

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Christian Holler (:decoder)]

The following testcase asserts on TI revision 3062ff7fef83 (run with -m -n -a),
tested on 64 bit:

var VERSION = "ECMA_2";
DoWhile(
        new DoWhileObject( false, false, false, VERSION )
);
function DoWhileObject( out1, out2, out3, in1 ) {
  this.breakIn=in1
}
function DoWhile( object ) {
    do if ( object.breakIn ) {} while ( false );
}

Comment 1

[Jan de Mooij [:jandem]]

Attachment: Patch

We could store a JSVAL_TYPE_UNKNOWN tag for loop-invariant properties. The other callers of learnType either pass a constant type or have a similar check.

Comment 2

[Brian Hackett [Laid off!]]

Comment on attachment 530269 [details] [diff] [review]
Patch

Nice, ran into this too when doing the overhaul-inlining patch.

Comment 3

[Jan de Mooij [:jandem]]

http://hg.mozilla.org/projects/jaegermonkey/rev/974e43d7adf8

Comment 4

[Christian Holler (:decoder)]

A testcase for this bug was automatically identified at js/src/jit-test/tests/jaeger/loops/bug654393.js.