654516 - Fix Sync button appearance in Modern

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Jens Hatlak (:InvisibleSmiley)]

Attachment: before and after

The Sync button (optional customizable toolbar item) currently looks bad in Modern. Ideally we'd have new images with correct sizes, but since we'd also need matching throbbers I don't think that'll happen any time soon and I'd like to have this for 2.1 still. 

With Classic, the buttons are much larger than the other toolbar buttons so there is not much we can do. With Modern MailNews there is no big (visible) issue, so nothing needs to be done there. Hence the following is for Modern/browser only.

Modern toolbarbuttons.css contains the following rule:

.toolbarbutton-icon[label]:not([label=""]),
.toolbarbutton-icon[type="menu"] {
  -moz-margin-end: 2px;
}

We don't want to lose such RTL-friendly settings, right?

Similarly, Modern button.css contains the following rule:

.toolbarbutton-1 > .toolbarbutton-icon, (...) {
  margin-bottom: 2px;
}

The Sync button exists in two sizes, 32x32 and 16x16.

a) 32x32: to match size 42x39 of the other button images we need to add 7px in height plus 2px bottom margin, 5px at the start and (5+2=7)px at the end.

b) 16x16: to match size 19x19 of the other button images we need to add 3px in height plus 2px bottom margin, 3px at the start and (3+2=5)px at the end.

Comment 1

[Jens Hatlak (:InvisibleSmiley)]

Attachment: patch [Checkin: comment 4]

Comment 2

[[e-mail]]

Comment on attachment 529783 [details] [diff] [review]
patch [Checkin: comment 4]

[Hmm, looks like the size of the small home button is smaller than the others to avoid making the bookmark bar taller.]

Comment 3

[Philip Chee]

> #PersonalToolbar[iconsize="small"] > toolbarpaletteitem > #home-button > .toolbarbutton-icon,
> #PersonalToolbar[iconsize="small"] > #home-button > .toolbarbutton-icon {
>   width: 16px;
>   height: 16px;
> }

I did it that way deliberately back when I was implementing toolbar customization.

Comment 4

[Jens Hatlak (:InvisibleSmiley)]

Comment on attachment 529783 [details] [diff] [review]
patch [Checkin: comment 4]

http://hg.mozilla.org/comm-central/rev/d84807ecf69c
http://hg.mozilla.org/releases/comm-2.0/rev/64a20aa7cbf7